Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2645693003: Revert of [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, v8-x87-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. (patchset #3 id:40001 of https://codereview.chromium.org/2639353002/ ) Reason for revert: compilation problems on mips Original issue's description: > [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32. > > On ia32 return statements in C++ automatically convert signalling NaNs > to quiet NaNs, even when bit_cast is used. This CL removes all uses of > bit_cast<float> and bit_cast<double> in the wasm compiler and wasm > interpreter. > > R=titzer@chromium.org, clemensh@chromium.org > > Review-Url: https://codereview.chromium.org/2639353002 > Cr-Commit-Position: refs/heads/master@{#42512} > Committed: https://chromium.googlesource.com/v8/v8/+/7739affa5b57e0d28674d476f63de60d71728fb6 TBR=clemensh@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review-Url: https://codereview.chromium.org/2645693003 Cr-Commit-Position: refs/heads/master@{#42514} Committed: https://chromium.googlesource.com/v8/v8/+/7ff8d317b1a9d31d1fe4ec9db4800be2c72746b6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -74 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/instruction.h View 1 chunk +0 lines, -17 lines 0 comments Download
M src/wasm/function-body-decoder.h View 2 chunks +2 lines, -6 lines 0 comments Download
M src/wasm/wasm-interpreter.h View 2 chunks +6 lines, -10 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 3 chunks +8 lines, -19 lines 0 comments Download
M test/cctest/wasm/test-run-wasm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M test/cctest/wasm/test-run-wasm-64.cc View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
ahaas
Created Revert of [wasm] Fix I32ReinterpretF32 and I64ReinterpretF64 on ia32.
3 years, 11 months ago (2017-01-19 17:00:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645693003/1
3 years, 11 months ago (2017-01-19 17:00:58 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 17:01:15 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7ff8d317b1a9d31d1fe4ec9db4800be2c72...

Powered by Google App Engine
This is Rietveld 408576698