Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 2645693002: Add libxkbcommon packages to precise sysroot (Closed)

Created:
3 years, 11 months ago by Tom (Use chromium acct)
Modified:
3 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, not to use - tonikitoo
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add libxkbcommon packages to precise sysroot This CL: * Adds libxkbcommon0 and libxkbcommon-dev packages to the precise sysroot. * Modifies sysroot-creator.sh to support multiple repos. (eg. main, universe, multiverse). * Rolls sysroots BUG=681562 R=dpranke@chromium.org CC=tonikitoo@chromium.org Review-Url: https://codereview.chromium.org/2645693002 Cr-Commit-Position: refs/heads/master@{#444475} Committed: https://chromium.googlesource.com/chromium/src/+/121fdaf4f383c1618d86f14fb4a210e52769e467

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -167 lines) Patch
M build/linux/sysroot_scripts/packagelist.jessie.amd64 View 5 chunks +26 lines, -26 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm View 5 chunks +26 lines, -26 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.arm64 View 5 chunks +28 lines, -28 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.i386 View 5 chunks +26 lines, -26 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.jessie.mipsel View 5 chunks +26 lines, -26 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.precise.amd64 View 1 chunk +2 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/packagelist.trusty.arm View 1 chunk +2 lines, -2 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator.sh View 3 chunks +22 lines, -11 lines 0 comments Download
M build/linux/sysroot_scripts/sysroot-creator-precise.sh View 2 chunks +3 lines, -0 lines 0 comments Download
M build/linux/sysroot_scripts/sysroots.json View 1 chunk +22 lines, -22 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Tom (Use chromium acct)
dpranke@ PTAL. libxkbcommon* were needed for wayland keyboard stuff (tonikitoo@ can clarify if needed). Unfortunately ...
3 years, 11 months ago (2017-01-18 20:39:50 UTC) #1
Dirk Pranke
lgtm
3 years, 11 months ago (2017-01-18 20:50:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645693002/1
3 years, 11 months ago (2017-01-18 20:51:18 UTC) #4
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 21:03:47 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/121fdaf4f383c1618d86f14fb4a2...

Powered by Google App Engine
This is Rietveld 408576698