Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2645683006:
UtilityProcessMojoClientBrowserTest: add enum for run options (Closed)
|
Created:
3 years, 11 months ago by Noel Gordon Modified:
3 years, 11 months ago CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review) Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionUtilityProcessMojoClientBrowserTest: add enum for run options
Add process run options as an enum for SANDBOXED, UNSANDBOXED,
and ELEVATED, rather than using booleans.
BUG=682549
Review-Url: https://codereview.chromium.org/2645683006
Cr-Commit-Position: refs/heads/master@{#445385}
Committed: https://chromium.googlesource.com/chromium/src/+/862ae960ab1fdb4503cd99398f7211473f1134f3
Patch Set 1 #
Total comments: 1
Patch Set 2 : Leave the #include order alone. #Messages
Total messages: 33 (25 generated)
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, ELEVATED rather than using booleans. BUG= ========== to ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG= ==========
Description was changed from ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG= ========== to ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG=682549 ==========
Description was changed from ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG=682549 ========== to ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG=682549 ==========
Patchset #1 (id:1) has been deleted
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Patchset #2 (id:40001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
noel@chromium.org changed reviewers: + sammc@chromium.org, tibell@chromium.org
lgtm
lgtm
https://codereview.chromium.org/2645683006/diff/20001/content/browser/utility... File content/browser/utility_process_mojo_client_browsertest.cc (right): https://codereview.chromium.org/2645683006/diff/20001/content/browser/utility... content/browser/utility_process_mojo_client_browsertest.cc:12: #include "content/public/browser/utility_process_mojo_client.h" In off-line chat, we checked the style guide about this. Seems it should be at the top (and have a 2 in its name :). Anyho, moving this line back to where it was.
The CQ bit was checked by noel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
noel@chromium.org changed reviewers: + boliu@chromium.org
+boliu for OWNERS.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by noel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from sammc@chromium.org, tibell@chromium.org Link to the patchset: https://codereview.chromium.org/2645683006/#ps60001 (title: "Leave the #include order alone.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1485188384428730,
"parent_rev": "b8e56c6b6d507d27a49f68db8e1034ed9e409887", "commit_rev":
"862ae960ab1fdb4503cd99398f7211473f1134f3"}
Message was sent while issue was closed.
Description was changed from ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG=682549 ========== to ========== UtilityProcessMojoClientBrowserTest: add enum for run options Add process run options as an enum for SANDBOXED, UNSANDBOXED, and ELEVATED, rather than using booleans. BUG=682549 Review-Url: https://codereview.chromium.org/2645683006 Cr-Commit-Position: refs/heads/master@{#445385} Committed: https://chromium.googlesource.com/chromium/src/+/862ae960ab1fdb4503cd99398f72... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as https://chromium.googlesource.com/chromium/src/+/862ae960ab1fdb4503cd99398f72... |
