Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1332)

Issue 2645683005: Make HeadlessWebContentsSecurityTest disable observer before completion. (Closed)

Created:
3 years, 11 months ago by Eric Seckler
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make HeadlessWebContentsSecurityTest disable observer before completion. Otherwise, a future call to OnSecurityStateChanged may cause a segmentation fault. BUG=682670 Review-Url: https://codereview.chromium.org/2645683005 Cr-Commit-Position: refs/heads/master@{#444726} Committed: https://chromium.googlesource.com/chromium/src/+/76edc3b46251f2bd425cd5b7bc90922fddb657d7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M headless/lib/headless_web_contents_browsertest.cc View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Eric Seckler
3 years, 11 months ago (2017-01-19 14:14:30 UTC) #2
alex clarke (OOO till 29th)
lgtm
3 years, 11 months ago (2017-01-19 14:23:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645683005/1
3 years, 11 months ago (2017-01-19 14:24:09 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 14:36:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/76edc3b46251f2bd425cd5b7bc90...

Powered by Google App Engine
This is Rietveld 408576698