Revert of [Parse] ParseInfo owns the parsing Zone.

Revert of [Parse] ParseInfo owns the parsing Zone. (patchset #4 id:60001 of https://codereview.chromium.org/2632123006/ )

Reason for revert:
Crashes on Windows in:
 CompilerDispatcherJobTest.CompileFailureToFinalize
 CompilerDispatcherJobTest.ScopeChain

Original issue's description:
> [Parse] ParseInfo owns the parsing Zone.
> 
> Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is
> in preperation for enabling background compilation jobs for inner functions
> share the AST in the outer-function's parse zone memory (read-only), with the
> and zone being released when all compilation jobs have completed.
> 
> BUG=v8:5203, v8:5215
> 
> Review-Url: https://codereview.chromium.org/2632123006
> Cr-Commit-Position: refs/heads/master@{#42539}
> Committed: https://chromium.googlesource.com/v8/v8/+/839b06b64fcaaaa9cceb2c3fd8fd5429e2932095

TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5203, v8:5215
Review-Url: https://codereview.chromium.org/2645613008
Cr-Commit-Position: refs/heads/master@{#42542}
Committed: https://chromium.googlesource.com/v8/v8/+/37cdb18bb7d5ce573e4ff4f6d48719e23e6a11b9

[rmcilroy, 2017-01-20 10:38:36]

The CQ bit was checked by rmcilroy@chromium.org

[rmcilroy, 2017-01-20 10:38:36]

Created Revert of [Parse] ParseInfo owns the parsing Zone.

[commit-bot: I haz the power, 2017-01-20 10:38:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 10:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 10:38:56]

Failed to apply patch for src/compiler.cc:
While running git apply --index -p1;
  error: patch failed: src/compiler.cc:507
  error: src/compiler.cc: patch does not apply

Patch:       src/compiler.cc
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index
9d0b7bc064f85b5d47f4c31844f5657bc3a08bff..e5ebae9294d5eb1868f13788968278876674ae37
100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -507,7 +507,8 @@
       shared->set_is_toplevel(false);
     }
 
-    ParseInfo parse_info(script);
+    Zone zone(isolate->allocator(), ZONE_NAME);
+    ParseInfo parse_info(&zone, script);
     parse_info.set_literal(literal);
     parse_info.set_shared_info(shared);
     parse_info.set_function_literal_id(shared->function_literal_id());
@@ -895,7 +896,8 @@
   Isolate* isolate = function->GetIsolate();
   VMState<COMPILER> state(isolate);
   PostponeInterruptsScope postpone(isolate);
-  ParseInfo parse_info(handle(function->shared()));
+  Zone zone(isolate->allocator(), ZONE_NAME);
+  ParseInfo parse_info(&zone, handle(function->shared()));
   CompilationInfo info(&parse_info, function);
 
   DCHECK(function->shared()->is_compiled());
@@ -1028,7 +1030,8 @@
     return entry;
   }
 
-  ParseInfo parse_info(handle(function->shared()));
+  Zone zone(isolate->allocator(), ZONE_NAME);
+  ParseInfo parse_info(&zone, handle(function->shared()));
   CompilationInfo info(&parse_info, function);
   Handle<Code> result;
   ASSIGN_RETURN_ON_EXCEPTION(isolate, result, GetUnoptimizedCode(&info), Code);
@@ -1207,7 +1210,8 @@
       code = isolate->builtins()->InterpreterEntryTrampoline();
       function->shared()->ReplaceCode(*code);
     } else {
-      ParseInfo parse_info(handle(function->shared()));
+      Zone zone(isolate->allocator(), ZONE_NAME);
+      ParseInfo parse_info(&zone, handle(function->shared()));
       CompilationInfo info(&parse_info, function);
       if (!GetUnoptimizedCode(&info).ToHandle(&code)) {
         return false;
@@ -1231,7 +1235,8 @@
   DCHECK(AllowCompilation::IsAllowed(isolate));
 
   // Start a compilation.
-  ParseInfo parse_info(shared);
+  Zone zone(isolate->allocator(), ZONE_NAME);
+  ParseInfo parse_info(&zone, shared);
   CompilationInfo info(&parse_info, Handle<JSFunction>::null());
   info.MarkAsDebug();
   if (GetUnoptimizedCode(&info).is_null()) {
@@ -1258,7 +1263,8 @@
   script->set_shared_function_infos(isolate->heap()->empty_fixed_array());
 
   // Start a compilation.
-  ParseInfo parse_info(script);
+  Zone zone(isolate->allocator(), ZONE_NAME);
+  ParseInfo parse_info(&zone, script);
   CompilationInfo info(&parse_info, Handle<JSFunction>::null());
   info.MarkAsDebug();
 
@@ -1269,7 +1275,7 @@
     // Check postconditions on success.
     DCHECK(!isolate->has_pending_exception());
     infos = LiveEditFunctionTracker::Collect(parse_info.literal(), script,
-                                             parse_info.zone(), isolate);
+                                             &zone, isolate);
   }
 
   // Restore the original function info list in order to remain side-effect
@@ -1393,7 +1399,8 @@
     script->set_compilation_type(Script::COMPILATION_TYPE_EVAL);
     Script::SetEvalOrigin(script, outer_info, eval_position);
 
-    ParseInfo parse_info(script);
+    Zone zone(isolate->allocator(), ZONE_NAME);
+    ParseInfo parse_info(&zone, script);
     CompilationInfo info(&parse_info, Handle<JSFunction>::null());
     parse_info.set_eval();
     parse_info.set_language_mode(language_mode);
@@ -1571,7 +1578,8 @@
     }
 
     // Compile the function and add it to the cache.
-    ParseInfo parse_info(script);
+    Zone zone(isolate->allocator(), ZONE_NAME);
+    ParseInfo parse_info(&zone, script);
     CompilationInfo info(&parse_info, Handle<JSFunction>::null());
     if (resource_options.IsModule()) parse_info.set_module();
     if (compile_options != ScriptCompiler::kNoCompileOptions) {

[rmcilroy, 2017-01-20 10:42:54]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2017-01-20 10:43:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 10:43:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484908974088340, "parent_rev":
"d2fe6dfadc213fb29e90fcd5cfeb742de926221d", "commit_rev":
"37cdb18bb7d5ce573e4ff4f6d48719e23e6a11b9"}

[commit-bot: I haz the power, 2017-01-20 10:43:21]

Description was changed from

==========
Revert of [Parse] ParseInfo owns the parsing Zone. (patchset #4 id:60001 of
https://codereview.chromium.org/2632123006/ )

Reason for revert:
Crashes on Windows in:
 CompilerDispatcherJobTest.CompileFailureToFinalize
 CompilerDispatcherJobTest.ScopeChain

Original issue's description:
> [Parse] ParseInfo owns the parsing Zone.
> 
> Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is
> in preperation for enabling background compilation jobs for inner functions
> share the AST in the outer-function's parse zone memory (read-only), with the
> and zone being released when all compilation jobs have completed.
> 
> BUG=v8:5203,v8:5215
> 
> Review-Url: https://codereview.chromium.org/2632123006
> Cr-Commit-Position: refs/heads/master@{#42539}
> Committed:
https://chromium.googlesource.com/v8/v8/+/839b06b64fcaaaa9cceb2c3fd8fd5429e29...

TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5203,v8:5215
==========

to

==========
Revert of [Parse] ParseInfo owns the parsing Zone. (patchset #4 id:60001 of
https://codereview.chromium.org/2632123006/ )

Reason for revert:
Crashes on Windows in:
 CompilerDispatcherJobTest.CompileFailureToFinalize
 CompilerDispatcherJobTest.ScopeChain

Original issue's description:
> [Parse] ParseInfo owns the parsing Zone.
> 
> Moves ownership of the parsing Zone to ParseInfo with a shared_ptr. This is
> in preperation for enabling background compilation jobs for inner functions
> share the AST in the outer-function's parse zone memory (read-only), with the
> and zone being released when all compilation jobs have completed.
> 
> BUG=v8:5203,v8:5215
> 
> Review-Url: https://codereview.chromium.org/2632123006
> Cr-Commit-Position: refs/heads/master@{#42539}
> Committed:
https://chromium.googlesource.com/v8/v8/+/839b06b64fcaaaa9cceb2c3fd8fd5429e29...

TBR=marja@chromium.org,mstarzinger@chromium.org,ahaas@chromium.org,verwaest@c...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=v8:5203,v8:5215

Review-Url: https://codereview.chromium.org/2645613008
Cr-Commit-Position: refs/heads/master@{#42542}
Committed:
https://chromium.googlesource.com/v8/v8/+/37cdb18bb7d5ce573e4ff4f6d48719e23e6...
==========

[commit-bot: I haz the power, 2017-01-20 10:43:22]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/37cdb18bb7d5ce573e4ff4f6d48719e23e6...