Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: content/renderer/media/media_stream_audio_track.cc

Issue 2645613005: MediaStreamTrack: Add echo-cancellation and device-id to getSettings (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_audio_track.cc
diff --git a/content/renderer/media/media_stream_audio_track.cc b/content/renderer/media/media_stream_audio_track.cc
index cb64f8af18db392cdee6789560a9c5e0659857c3..1a7ed61d16b908294b2278594c42c63962fa248a 100644
--- a/content/renderer/media/media_stream_audio_track.cc
+++ b/content/renderer/media/media_stream_audio_track.cc
@@ -143,8 +143,8 @@ void MediaStreamAudioTrack::OnData(const media::AudioBus& audio_bus,
void MediaStreamAudioTrack::getSettings(
blink::WebMediaStreamTrack::Settings& settings) {
- // TODO(hta): Extract the real value.
- settings.deviceId = blink::WebString("audio device ID");
+ // At the moment, all audio values are extracted from the source,
+ // not the track.
}
} // namespace content

Powered by Google App Engine
This is Rietveld 408576698