Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2033)

Unified Diff: content/renderer/media/external_media_stream_audio_source.cc

Issue 2645613005: MediaStreamTrack: Add echo-cancellation and device-id to getSettings (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/external_media_stream_audio_source.cc
diff --git a/content/renderer/media/external_media_stream_audio_source.cc b/content/renderer/media/external_media_stream_audio_source.cc
index 7c2977c2907c46249730468bb2f63b81ffbe75a3..936e1c2153edd2a22d48903dccf73a91de1f258c 100644
--- a/content/renderer/media/external_media_stream_audio_source.cc
+++ b/content/renderer/media/external_media_stream_audio_source.cc
@@ -30,6 +30,12 @@ ExternalMediaStreamAudioSource::~ExternalMediaStreamAudioSource() {
EnsureSourceIsStopped();
}
+void ExternalMediaStreamAudioSource::getSettings(
+ blink::WebMediaStreamTrack::Settings& settings) {
+ // This source type does not support echo cancellation.
+ settings.setEchoCancellation(false);
+}
+
bool ExternalMediaStreamAudioSource::EnsureSourceIsStarted() {
DCHECK(thread_checker_.CalledOnValidThread());
if (was_started_)

Powered by Google App Engine
This is Rietveld 408576698