Serialize type and attribute selectors as identifiers

Serialize type and attribute selectors as identifiers

Per [1], both the element name of a type selector and the attribute name
of an attribute selector - as well as their corresponding namespace
prefix (if any) - should be serialized as identifiers [2].

[1] https://drafts.csswg.org/cssom/#serialize-a-simple-selector
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier

BUG=681814
Review-Url: https://codereview.chromium.org/2645563002
Cr-Commit-Position: refs/heads/master@{#444766}
Committed: https://chromium.googlesource.com/chromium/src/+/97b5d7d2b375ae960a7b8084591815e30ae19832

[fs, 2017-01-18 14:45:14]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 14:46:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-01-18 15:49:54]

fs@opera.com changed reviewers:
+ rune@opera.com

[commit-bot: I haz the power, 2017-01-18 16:12:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 16:12:26]

Dry run: This issue passed the CQ dry run.

[rune, 2017-01-18 23:29:24]

lgtm with some nits.

For test coverage, testing a case of "escaped as code point" would be good too.

https://codereview.chromium.org/2645563002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html
(right):

https://codereview.chromium.org/2645563002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html:9:
var weird_ns_rule = "@namespace ns\\:odd url(ns);";
Nit: I'd probably call it "escaped_ns_rule" instead.

[fs, 2017-01-19 11:39:43]

The CQ bit was checked by fs@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 11:40:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[fs, 2017-01-19 11:43:27]

On 2017/01/18 at 23:29:24, rune wrote:
...
> For test coverage, testing a case of "escaped as code point" would be good
too.

Added.

https://codereview.chromium.org/2645563002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html
(right):

https://codereview.chromium.org/2645563002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/cssom/serialize-namespaced-type-selectors.html:9:
var weird_ns_rule = "@namespace ns\\:odd url(ns);";
On 2017/01/18 at 23:29:24, rune wrote:
> Nit: I'd probably call it "escaped_ns_rule" instead.

Yes, that's probably a little less colloquial =). Changed.

[commit-bot: I haz the power, 2017-01-19 13:42:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 13:42:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[fs, 2017-01-19 16:47:32]

The CQ bit was checked by fs@opera.com

[fs, 2017-01-19 16:47:32]

The patchset sent to the CQ was uploaded after l-g-t-m from rune@opera.com
Link to the patchset: https://codereview.chromium.org/2645563002/#ps20001
(title: "weird -> escaped; add "serialize character as code point" test")

[commit-bot: I haz the power, 2017-01-19 16:47:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 16:52:29]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484844452261310,
"parent_rev": "36350b6d4cdcf66610ed46bf12f74f34aacfe2d8", "commit_rev":
"97b5d7d2b375ae960a7b8084591815e30ae19832"}

[commit-bot: I haz the power, 2017-01-19 16:52:58]

Description was changed from

==========
Serialize type and attribute selectors as identifiers

Per [1], both the element name of a type selector and the attribute name
of an attribute selector - as well as their corresponding namespace
prefix (if any) - should be serialized as identifiers [2].

[1] https://drafts.csswg.org/cssom/#serialize-a-simple-selector
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier

BUG=681814
==========

to

==========
Serialize type and attribute selectors as identifiers

Per [1], both the element name of a type selector and the attribute name
of an attribute selector - as well as their corresponding namespace
prefix (if any) - should be serialized as identifiers [2].

[1] https://drafts.csswg.org/cssom/#serialize-a-simple-selector
[2] https://drafts.csswg.org/cssom/#serialize-an-identifier

BUG=681814

Review-Url: https://codereview.chromium.org/2645563002
Cr-Commit-Position: refs/heads/master@{#444766}
Committed:
https://chromium.googlesource.com/chromium/src/+/97b5d7d2b375ae960a7b80845918...
==========

[commit-bot: I haz the power, 2017-01-19 16:52:59]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/97b5d7d2b375ae960a7b80845918...