Files app: Fix error of image loader which is caused by missing script.

Files app: Fix error of image loader which is caused by missing script.

This change should have been included in https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139, 636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2645533002
Cr-Commit-Position: refs/heads/master@{#444575}
Committed: https://chromium.googlesource.com/chromium/src/+/e9762587b94da23ce580995d1c7fa6ff7bf456f5

[fukino, 2017-01-18 12:56:34]

Description was changed from

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=636289
TEST=manually tested
==========

to

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-01-18 12:56:40]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[fukino, 2017-01-18 12:56:51]

fukino@chromium.org changed reviewers:
+ yamaguchi@chromium.org

[fukino, 2017-01-18 12:56:51]

PTAL

[commit-bot: I haz the power, 2017-01-18 12:56:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[oka, 2017-01-18 12:58:07]

oka@chromium.org changed reviewers:
+ oka@chromium.org

[oka, 2017-01-18 12:58:08]

lgtm

[yamaguchi, 2017-01-18 12:59:31]

lgtm

[oka, 2017-01-18 13:00:15]

Is there no bug for the issue this CL fixes?

[fukino, 2017-01-18 13:00:16]

Thank you all for really quick review :)

[yamaguchi, 2017-01-18 13:00:52]

On 2017/01/18 12:59:31, yamaguchi wrote:
> lgtm

Also add 682139 to BUG=.

[fukino, 2017-01-18 13:01:27]

Description was changed from

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-01-18 13:02:07]

On 2017/01/18 13:00:52, yamaguchi wrote:
> On 2017/01/18 12:59:31, yamaguchi wrote:
> > lgtm
> 
> Also add 682139 to BUG=.

Updated BUG line.
Thank you for finding the issue and filing the bug.

[commit-bot: I haz the power, 2017-01-18 13:27:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 13:27:55]

Dry run: This issue passed the CQ dry run.

[yamaguchi, 2017-01-18 14:07:25]

The CQ bit was checked by yamaguchi@chromium.org

[commit-bot: I haz the power, 2017-01-18 14:07:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yamaguchi, 2017-01-18 14:08:52]

The CQ bit was unchecked by yamaguchi@chromium.org

[yamaguchi, 2017-01-18 14:12:40]

On 2017/01/18 13:02:07, fukino wrote:
> On 2017/01/18 13:00:52, yamaguchi wrote:
> > On 2017/01/18 12:59:31, yamaguchi wrote:
> > > lgtm
> > 
> > Also add 682139 to BUG=.
> 
> Updated BUG line.
> Thank you for finding the issue and filing the bug.

Would it be better to have the both Issue IDs?
BUG=682139,636289

[oka, 2017-01-18 23:48:17]

+1

2017年1月18日(水) 23:12 <yamaguchi@chromium.org>:

> On 2017/01/18 13:02:07, fukino wrote:
> > On 2017/01/18 13:00:52, yamaguchi wrote:
> > > On 2017/01/18 12:59:31, yamaguchi wrote:
> > > > lgtm
> > >
> > > Also add 682139 to BUG=.
> >
> > Updated BUG line.
> > Thank you for finding the issue and filing the bug.
>
> Would it be better to have the both Issue IDs?
> BUG=682139,636289
>
> https://codereview.chromium.org/2645533002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[fukino, 2017-01-19 00:45:54]

Description was changed from

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139,636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-01-19 00:46:00]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-01-19 00:46:22]

> Would it be better to have the both Issue IDs?
> BUG=682139,636289

Done

[commit-bot: I haz the power, 2017-01-19 00:46:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 00:51:28]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484786760082410, "parent_rev":
"3ce1a24a7e23be0e5f01d38a943b51cf87a01895", "commit_rev":
"e9762587b94da23ce580995d1c7fa6ff7bf456f5"}

[commit-bot: I haz the power, 2017-01-19 00:51:55]

Description was changed from

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139,636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Fix error of image loader which is caused by missing script.

This change should have been included in
https://codereview.chromium.org/2634213003/.
Missing this diff causes the error.

BUG=682139,636289
TEST=manually tested
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2645533002
Cr-Commit-Position: refs/heads/master@{#444575}
Committed:
https://chromium.googlesource.com/chromium/src/+/e9762587b94da23ce580995d1c7f...
==========

[commit-bot: I haz the power, 2017-01-19 00:51:56]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9762587b94da23ce580995d1c7f...