Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 2645523004: mash: Fix TabletPowerButtonController segfault. (Closed)

Created:
3 years, 11 months ago by Daniel Erat
Modified:
3 years, 11 months ago
CC:
chromium-reviews, kalyank, sadrul, oshima+watch_chromium.org, derat+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Fix TabletPowerButtonController segfault. Make TabletPowerButtonController check that ui::InputDeviceManager exists before trying to register itself with it. BUG=682403, 682460 Review-Url: https://codereview.chromium.org/2645523004 Cr-Commit-Position: refs/heads/master@{#444571} Committed: https://chromium.googlesource.com/chromium/src/+/7493b52a7df965340262a60de51780cbf978dbff

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M ash/system/chromeos/power/tablet_power_button_controller.cc View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Daniel Erat
james, can you check if this fixes the crash you're seeing? it gets rid of ...
3 years, 11 months ago (2017-01-18 23:42:26 UTC) #2
James Cook
It'll be a few minutes before I can test this (in the middle of some ...
3 years, 11 months ago (2017-01-19 00:12:02 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645523004/1
3 years, 11 months ago (2017-01-19 00:38:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/7493b52a7df965340262a60de51780cbf978dbff
3 years, 11 months ago (2017-01-19 00:46:21 UTC) #12
James Cook
3 years, 11 months ago (2017-01-19 01:43:01 UTC) #13
Message was sent while issue was closed.
On 2017/01/19 00:46:21, commit-bot: I haz the power wrote:
> Committed patchset #1 (id:1) as
>
https://chromium.googlesource.com/chromium/src/+/7493b52a7df965340262a60de517...

This fixes chrome --mash on device for me with cave (which uses touchview).

Powered by Google App Engine
This is Rietveld 408576698