[turbofan] Mark fast StringAdd as not causing side effects.

[turbofan] Mark fast StringAdd as not causing side effects.

When StringAdd builtin is used to concatenate two primitive values,
we know that the operation might throw, but cannot trigger any other
observable side effect, so it shouldn't flush the LoadElimination state.

R=jarin@chromium.org
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2645523002
Cr-Commit-Position: refs/heads/master@{#42489}
Committed: https://chromium.googlesource.com/v8/v8/+/975430161ee1f67b9c21cfaf6129e05cff5a63cf

[Benedikt Meurer, 2017-01-18 12:15:13]

The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 12:15:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 12:42:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 12:42:04]

Dry run: This issue passed the CQ dry run.

[Benedikt Meurer, 2017-01-18 13:25:11]

Hey Jaro,

Here's a simple fix for StringAdd flushing the LoadElimination table (spotted in
Ember).
Please take a look.

Thanks,
Benedikt

[Jarin, 2017-01-19 06:41:07]

lgtm

[Benedikt Meurer, 2017-01-19 06:42:26]

The CQ bit was checked by bmeurer@chromium.org

[commit-bot: I haz the power, 2017-01-19 06:42:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 06:44:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484808146680970, "parent_rev":
"140d4df7954259e60a555efc0b2d00a9c924564c", "commit_rev":
"975430161ee1f67b9c21cfaf6129e05cff5a63cf"}

[commit-bot: I haz the power, 2017-01-19 06:44:35]

Description was changed from

==========
[turbofan] Mark fast StringAdd as not causing side effects.

When StringAdd builtin is used to concatenate two primitive values,
we know that the operation might throw, but cannot trigger any other
observable side effect, so it shouldn't flush the LoadElimination state.

R=jarin@chromium.org
BUG=v8:5267
==========

to

==========
[turbofan] Mark fast StringAdd as not causing side effects.

When StringAdd builtin is used to concatenate two primitive values,
we know that the operation might throw, but cannot trigger any other
observable side effect, so it shouldn't flush the LoadElimination state.

R=jarin@chromium.org
BUG=v8:5267

Review-Url: https://codereview.chromium.org/2645523002
Cr-Commit-Position: refs/heads/master@{#42489}
Committed:
https://chromium.googlesource.com/v8/v8/+/975430161ee1f67b9c21cfaf6129e05cff5...
==========

[commit-bot: I haz the power, 2017-01-19 06:44:35]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/975430161ee1f67b9c21cfaf6129e05cff5...