FileSystem: Migrate ExecutionContextTask to WTF::Closure

FileSystem: Migrate ExecutionContextTask to WTF::Closure

BUG=625927
Review-Url: https://codereview.chromium.org/2645473005
Cr-Commit-Position: refs/heads/master@{#444661}
Committed: https://chromium.googlesource.com/chromium/src/+/e65b92f52d560ffa0d36850693ded14171719817

[nhiroki, 2017-01-19 03:56:22]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 03:56:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 03:56:48]

Patchset #1 (id:1) has been deleted

[nhiroki, 2017-01-19 03:57:41]

nhiroki@chromium.org changed reviewers:
+ tzik@chromium.org

[nhiroki, 2017-01-19 03:57:42]

PTAL. Does this head to the right direction?

[tzik, 2017-01-19 04:16:09]

Looks good.

https://codereview.chromium.org/2645473005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp (right):

https://codereview.chromium.org/2645473005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp:213:
WTF::bind(&runCallback, wrapPersistent(executionContext),
Can we use wrapWeakPersistent and check its value in runCallback to keep the old
behavior?

[haraken, 2017-01-19 04:20:54]

LGTM with tzik@'s comment addressed.

[nhiroki, 2017-01-19 04:26:36]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 04:26:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 04:32:29]

Patchset #2 (id:40001) has been deleted

[nhiroki, 2017-01-19 04:32:58]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 04:33:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2017-01-19 04:33:40]

Thanks for your comments. Updated.

https://codereview.chromium.org/2645473005/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp (right):

https://codereview.chromium.org/2645473005/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/filesystem/DOMFileSystem.cpp:213:
WTF::bind(&runCallback, wrapPersistent(executionContext),
On 2017/01/19 04:16:09, tzik wrote:
> Can we use wrapWeakPersistent and check its value in runCallback to keep the
old
> behavior?

Done.

[tzik, 2017-01-19 04:57:55]

lgtm

[nhiroki, 2017-01-19 05:28:26]

The CQ bit was unchecked by nhiroki@chromium.org

[nhiroki, 2017-01-19 05:28:31]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2017-01-19 05:28:31]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2645473005/#ps60001
(title: "wrapWeakPersistent")

[commit-bot: I haz the power, 2017-01-19 05:28:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 06:11:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484803711355030,
"parent_rev": "bd1f56eef55c9a57303453e7a4c9e1c09b241971", "commit_rev":
"e65b92f52d560ffa0d36850693ded14171719817"}

[commit-bot: I haz the power, 2017-01-19 06:12:25]

Description was changed from

==========
FileSystem: Migrate ExecutionContextTask to WTF::Closure

BUG=625927
==========

to

==========
FileSystem: Migrate ExecutionContextTask to WTF::Closure

BUG=625927

Review-Url: https://codereview.chromium.org/2645473005
Cr-Commit-Position: refs/heads/master@{#444661}
Committed:
https://chromium.googlesource.com/chromium/src/+/e65b92f52d560ffa0d36850693de...
==========

[commit-bot: I haz the power, 2017-01-19 06:12:28]

Committed patchset #2 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e65b92f52d560ffa0d36850693de...