Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 2645463002: Move TextFinder's deferred scoping work to the unspeced timer task queue (Closed)

Created:
3 years, 11 months ago by dcheng
Modified:
3 years, 11 months ago
Reviewers:
haraken, paulmeyer
CC:
chromium-reviews, blink-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move TextFinder's deferred scoping work to the unspeced timer task queue Find-in-page intentionally breaks up the work into chunks to avoid blocking the main thread for too long. Schedule the chunks on the unspeced timer task queue, since it's not necessarily important to complete this work immediately. BUG=624694 Review-Url: https://codereview.chromium.org/2645463002 Cr-Commit-Position: refs/heads/master@{#444402} Committed: https://chromium.googlesource.com/chromium/src/+/198b275565e9160f11ae09c8e97c037ec79bee8c

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/web/TextFinder.cpp View 1 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
dcheng
3 years, 11 months ago (2017-01-18 10:10:28 UTC) #7
haraken
LGTM
3 years, 11 months ago (2017-01-18 10:21:56 UTC) #8
paulmeyer
lgtm
3 years, 11 months ago (2017-01-18 14:47:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645463002/20001
3 years, 11 months ago (2017-01-18 16:54:52 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 17:03:53 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/198b275565e9160f11ae09c8e97c...

Powered by Google App Engine
This is Rietveld 408576698