Properly detect if Chrome is incognito

Properly detect if Chrome is incognito

I misunderstood the comment for HasOffTheRecordChromeBrowserState().

BUG=674441
Review-Url: https://codereview.chromium.org/2645453003
Cr-Commit-Position: refs/heads/master@{#444412}
Committed: https://chromium.googlesource.com/chromium/src/+/11764f420eec90c09ae7001aa753fef1e343c493

[sfiera, 2017-01-18 17:14:21]

The CQ bit was checked by sfiera@chromium.org to run a CQ dry run

[sfiera, 2017-01-18 17:14:35]

sfiera@chromium.org changed reviewers:
+ marq@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:14:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:23:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:23:27]

Dry run: This issue passed the CQ dry run.

[noyau (Ping after 24h), 2017-01-18 17:30:16]

noyau@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2017-01-18 17:30:16]

lgtm

[sfiera, 2017-01-18 17:35:50]

The CQ bit was checked by sfiera@chromium.org

[commit-bot: I haz the power, 2017-01-18 17:36:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 17:40:25]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484760950561940, "parent_rev":
"4c680a2ef5928af16e36c4dbc4bc9f6dc79379cc", "commit_rev":
"11764f420eec90c09ae7001aa753fef1e343c493"}

[commit-bot: I haz the power, 2017-01-18 17:41:03]

Description was changed from

==========
Properly detect if Chrome is incognito

I misunderstood the comment for HasOffTheRecordChromeBrowserState().

BUG=674441
==========

to

==========
Properly detect if Chrome is incognito

I misunderstood the comment for HasOffTheRecordChromeBrowserState().

BUG=674441

Review-Url: https://codereview.chromium.org/2645453003
Cr-Commit-Position: refs/heads/master@{#444412}
Committed:
https://chromium.googlesource.com/chromium/src/+/11764f420eec90c09ae7001aa753...
==========

[commit-bot: I haz the power, 2017-01-18 17:41:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/11764f420eec90c09ae7001aa753...

[sdefresne, 2017-01-19 12:14:07]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2017-01-19 12:14:08]

https://codereview.chromium.org/2645453003/diff/1/ios/chrome/browser/ui/webui...
File ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc (right):

https://codereview.chromium.org/2645453003/diff/1/ios/chrome/browser/ui/webui...
ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc:60: return state ==
state->GetOriginalChromeBrowserState();
Why not just use IsOffTheRecord() instead?

  auto* state = ios::ChromeBrowserState::FromWebUIIOS(web_ui());
  return state->IsOffTheRecord();

[sdefresne, 2017-01-19 12:14:25]

On 2017/01/19 12:14:08, sdefresne wrote:
>
https://codereview.chromium.org/2645453003/diff/1/ios/chrome/browser/ui/webui...
> File ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc (right):
> 
>
https://codereview.chromium.org/2645453003/diff/1/ios/chrome/browser/ui/webui...
> ios/chrome/browser/ui/webui/ntp_tiles_internals_ui.cc:60: return state ==
> state->GetOriginalChromeBrowserState();
> Why not just use IsOffTheRecord() instead?
> 
>   auto* state = ios::ChromeBrowserState::FromWebUIIOS(web_ui());
>   return state->IsOffTheRecord();

I meant !state->IsOffTheRecord();