Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 2645403010: Update Physical Web omnibox icons to match Chrome's theme (Closed)

Created:
3 years, 11 months ago by mattreynolds
Modified:
3 years, 11 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, oshima+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Physical Web omnibox icons to match Chrome's theme An icon with the Physical Web logo is shown on the right end of Physical Web omnibox suggestions. Previously, these icons used colors that looked out of place with the other omnibox icons. This CL replaces the PW icons with new ones that match the theme. BUG=685343 Review-Url: https://codereview.chromium.org/2645403010 Cr-Commit-Position: refs/heads/master@{#446206} Committed: https://chromium.googlesource.com/chromium/src/+/9896346c3c7b07539e00668b9967a6e714dfeeac

Patch Set 1 #

Patch Set 2 : rebuilt icons #

Patch Set 3 : alignment #

Messages

Total messages: 13 (6 generated)
mattreynolds
I attached some before and after screenshots to the bug.
3 years, 11 months ago (2017-01-25 20:42:45 UTC) #2
mattreynolds
Scott rebuilt the icons for us, I updated the screenshots on the bug. We're replacing ...
3 years, 11 months ago (2017-01-26 01:53:44 UTC) #3
mattreynolds
Hi Rohit, PTAL
3 years, 11 months ago (2017-01-26 01:58:50 UTC) #6
rohitrao (ping after 24h)
lgtm
3 years, 11 months ago (2017-01-26 01:59:34 UTC) #7
mattreynolds
(the resources have already been run through optimize-png-files)
3 years, 11 months ago (2017-01-26 01:59:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645403010/40001
3 years, 11 months ago (2017-01-26 02:01:09 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-26 02:15:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9896346c3c7b07539e00668b9967...

Powered by Google App Engine
This is Rietveld 408576698