Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2645403006:
[Devtools] Fixed url in Audits (Closed)
Description[Devtools] Fixed url in Audits
This patch fixes areas where NetworkRequest.url conversion was missed
because file lacked doctype.
R=dgozman,luoe
BUG=680054
NOPRESUBMIT=true
NOTRY=true
Review-Url: https://codereview.chromium.org/2627073003
Cr-Commit-Position: refs/heads/master@{#444962}
(cherry picked from commit 5b078604227b8dd8864657954161097abc3091ee)
Review-Url: https://codereview.chromium.org/2645403006
Cr-Commit-Position: refs/branch-heads/2987@{#35}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/ec93b8208672b52bd9ace6618586f849c2b65364
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
PTL
Description was changed from ========== [Devtools] Fixed url in Audits This patch fixes areas where NetworkRequest.url conversion was missed because file lacked doctype. R=dgozman,luoe BUG=680054 Review-Url: https://codereview.chromium.org/2627073003 Cr-Commit-Position: refs/heads/master@{#444962} (cherry picked from commit 5b078604227b8dd8864657954161097abc3091ee) ========== to ========== [Devtools] Fixed url in Audits This patch fixes areas where NetworkRequest.url conversion was missed because file lacked doctype. R=dgozman,luoe BUG=680054 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2627073003 Cr-Commit-Position: refs/heads/master@{#444962} (cherry picked from commit 5b078604227b8dd8864657954161097abc3091ee) ==========
kozyatinskiy@chromium.org changed reviewers: + kozyatinskiy@chromium.org
lgtm
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485199254348430, "parent_rev":
"693fec55b955d1b4b63c924a0ab8d4820740db99", "commit_rev":
"b1c378e54c65e92393d583f853d694c8c2507290"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485199254348430, "parent_rev":
"693fec55b955d1b4b63c924a0ab8d4820740db99", "commit_rev":
"b1c378e54c65e92393d583f853d694c8c2507290"}
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485199254348430, "parent_rev":
"693fec55b955d1b4b63c924a0ab8d4820740db99", "commit_rev":
"b1c378e54c65e92393d583f853d694c8c2507290"}
The CQ bit was unchecked by commit-bot@chromium.org
Prior attempt to commit was detected, but we were not able to check whether the issue was successfully committed. Please check Git history manually and re-check CQ or close this issue as needed.
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by allada@chromium.org
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1485201371324810, "parent_rev":
"20753e04d07a7f260f53503072b68276295dd667", "commit_rev":
"ec93b8208672b52bd9ace6618586f849c2b65364"}
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Fixed url in Audits This patch fixes areas where NetworkRequest.url conversion was missed because file lacked doctype. R=dgozman,luoe BUG=680054 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2627073003 Cr-Commit-Position: refs/heads/master@{#444962} (cherry picked from commit 5b078604227b8dd8864657954161097abc3091ee) ========== to ========== [Devtools] Fixed url in Audits This patch fixes areas where NetworkRequest.url conversion was missed because file lacked doctype. R=dgozman,luoe BUG=680054 NOPRESUBMIT=true NOTRY=true Review-Url: https://codereview.chromium.org/2627073003 Cr-Commit-Position: refs/heads/master@{#444962} (cherry picked from commit 5b078604227b8dd8864657954161097abc3091ee) Review-Url: https://codereview.chromium.org/2645403006 Cr-Commit-Position: refs/branch-heads/2987@{#35} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/ec93b8208672b52bd9ace6618586... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ec93b8208672b52bd9ace6618586... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
