Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2645393002: Add some tracing to NewTabPage. (Closed)

Created:
3 years, 11 months ago by Michael van Ouwerkerk
Modified:
3 years, 10 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, noyau+watch_chromium.org, ntp-dev+reviews_chromium.org, agrieve+watch_chromium.org, vitaliii
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add some tracing to NewTabPage. Review-Url: https://codereview.chromium.org/2645393002 Cr-Commit-Position: refs/heads/master@{#448002} Committed: https://chromium.googlesource.com/chromium/src/+/4cca33f07610e310cc5504110a102f747eff4319

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address review comments from bauerb. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -1 line) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java View 1 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 9 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Michael van Ouwerkerk
Bernhard, could you take a look please?
3 years, 11 months ago (2017-01-23 15:44:21 UTC) #2
Bernhard Bauer
lgtm https://codereview.chromium.org/2645393002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/2645393002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode325 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:325: TraceEvent.begin("NewTabPageView.initialize()"); Would it make sense to use `TAG ...
3 years, 11 months ago (2017-01-23 16:15:24 UTC) #3
Michael van Ouwerkerk
https://codereview.chromium.org/2645393002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java (right): https://codereview.chromium.org/2645393002/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java#newcode325 chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java:325: TraceEvent.begin("NewTabPageView.initialize()"); On 2017/01/23 16:15:24, Bernhard Bauer wrote: > Would ...
3 years, 10 months ago (2017-02-03 15:07:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645393002/20001
3 years, 10 months ago (2017-02-03 15:08:18 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-03 16:39:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4cca33f07610e310cc5504110a10...

Powered by Google App Engine
This is Rietveld 408576698