Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2645383002: Move 'id'-related invalidation to SVGElement::attributeChanged (Closed)

Created:
3 years, 11 months ago by fs
Modified:
3 years, 11 months ago
Reviewers:
pdr., Stephen Chennney
CC:
fs, blink-reviews, chromium-reviews, krit, f(malita), gyuyoung2, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move 'id'-related invalidation to SVGElement::attributeChanged There's no reason for 'id'-related invalidation to reside in SVGElement::svgAttributeChanged since it has no interaction with an (animated) SVG DOM attribute. Move it to SVGElement::attributeChanged instead. This will also enable us to make use of the old/new value that is available in attributeChanged(). BUG=454767 Review-Url: https://codereview.chromium.org/2645383002 Cr-Commit-Position: refs/heads/master@{#445393} Committed: https://chromium.googlesource.com/chromium/src/+/cc2c85c51df265ff8ab049b080ff89910afe45f8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -13 lines) Patch
M third_party/WebKit/Source/core/svg/SVGElement.cpp View 2 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
fs
3 years, 11 months ago (2017-01-23 14:55:16 UTC) #6
Stephen Chennney
lgtm
3 years, 11 months ago (2017-01-23 17:03:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645383002/1
3 years, 11 months ago (2017-01-23 17:04:06 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 17:08:38 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cc2c85c51df265ff8ab049b080ff...

Powered by Google App Engine
This is Rietveld 408576698