Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2645363002: Copy the original request header for navigation preload requests (Closed)

Created:
3 years, 11 months ago by horo
Modified:
3 years, 11 months ago
Reviewers:
falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, shimazu+serviceworker_chromium.org, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, darin-cc_chromium.org, kinuko+watch, tzik, falken+watch_chromium.org, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy the original request header for navigation preload requests In the currentl implementation, HTTP request header which was set in the browser process such as Upgrade-Insecure-Requests are omitted. BUG=649558 Review-Url: https://codereview.chromium.org/2645363002 Cr-Commit-Position: refs/heads/master@{#445660} Committed: https://chromium.googlesource.com/chromium/src/+/407c1eaf8105a6dbd05a12f8470b1e5fa6ec3c59

Patch Set 1 #

Messages

Total messages: 14 (9 generated)
horo
falken@ please review this.
3 years, 11 months ago (2017-01-24 01:48:56 UTC) #6
falken
lgtm. Can we expect Upgrade-Insecure-Requests to be sent by all evergreen browsers? If not it ...
3 years, 11 months ago (2017-01-24 04:33:51 UTC) #7
horo
On 2017/01/24 04:33:51, falken wrote: > lgtm. Can we expect Upgrade-Insecure-Requests to be sent by ...
3 years, 11 months ago (2017-01-24 05:41:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645363002/1
3 years, 11 months ago (2017-01-24 05:41:44 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 05:46:20 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/407c1eaf8105a6dbd05a12f8470b...

Powered by Google App Engine
This is Rietveld 408576698