Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 2645273004: [wasm] Fix a typo in wasm-js.cc (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix a typo in wasm-js.cc I guess that a comparison with i::wasm::kV8MaxWasmTableSize was not intended here. I did not add a test because I do not even know if it is even possible to create a WasmMemoryObject with maximum_pages > i::wasm::kV8MaxWasmMemoryPages. Maybe we should replace the condition with a Check instead. R=titzer@chromium.org Review-Url: https://codereview.chromium.org/2645273004 Cr-Commit-Position: refs/heads/master@{#42596} Committed: https://chromium.googlesource.com/v8/v8/+/1f069202e11864e509f493ac13c571adcb7b5736

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/wasm/wasm-js.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 11 months ago (2017-01-23 10:24:07 UTC) #1
titzer
lgtm nice catch!
3 years, 11 months ago (2017-01-23 10:28:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645273004/1
3 years, 11 months ago (2017-01-23 10:54:33 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 10:56:13 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/1f069202e11864e509f493ac13c571adcb7...

Powered by Google App Engine
This is Rietveld 408576698