[tubofan] escape analysis crashes only in debug builds for unaccounted opcodes

[tubofan] teach escape analysis about ObjectIsNonCallable

R=mstarzinger@chromium.org, bmeurer@chromium.org

BUG=chromium:669242
Review-Url: https://codereview.chromium.org/2645273003
Cr-Commit-Position: refs/heads/master@{#42630}
Committed: https://chromium.googlesource.com/v8/v8/+/e225251f256472562e1fc79feec2d7203b15e443

[Michael Starzinger, 2017-01-23 17:52:14]

LGTM from my end. Benedikt, you had an opinion about keeping this list explicit
in the past. Are you fine with changing it to a DCHECK, in order to "hide" the
issues from Chrome crashes in the wild?

[Michael Starzinger, 2017-01-23 17:52:33]

Description was changed from

==========
[tubofan] escape analysis crashes only in debug builds for unaccounted opcodes

R=mstarzinger@chromium.org

BUG=chromium:669242
==========

to

==========
[tubofan] escape analysis crashes only in debug builds for unaccounted opcodes

R=mstarzinger@chromium.org

BUG=chromium:669242
==========

[Michael Starzinger, 2017-01-23 17:52:33]

mstarzinger@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Michael Starzinger, 2017-01-23 17:52:33]

mstarzinger@chromium.org changed required reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2017-01-24 12:34:33]

LGTM % nits

https://codereview.chromium.org/2645273003/diff/20001/src/compiler/escape-ana...
File src/compiler/escape-analysis.cc (right):

https://codereview.chromium.org/2645273003/diff/20001/src/compiler/escape-ana...
src/compiler/escape-analysis.cc:840: PrintF("Encountered unaccounted use by #%d
(%s)\n", use->id(),
Nit: Do V8_Fatal here please.

https://codereview.chromium.org/2645273003/diff/20001/src/compiler/escape-ana...
src/compiler/escape-analysis.cc:842: DCHECK(false);
Nit: Please keep UNREACHABLE()

[Tobias Tebbi, 2017-01-24 12:44:23]

Description was changed from

==========
[tubofan] escape analysis crashes only in debug builds for unaccounted opcodes

R=mstarzinger@chromium.org

BUG=chromium:669242
==========

to

==========
[tubofan] teach escape analysis about ObjectIsNonCallable

R=mstarzinger@chromium.org, bmeurer@chromium.org

BUG=chromium:669242
==========

[Tobias Tebbi, 2017-01-24 12:45:06]

The CQ bit was checked by tebbi@chromium.org

[Tobias Tebbi, 2017-01-24 12:45:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2645273003/#ps40001
(title: "restore strict check")

[commit-bot: I haz the power, 2017-01-24 12:45:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 13:18:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485261906892840,
"parent_rev": "a920c0d92bd5d1c59a23ba4c103c96d7724d0460", "commit_rev":
"e225251f256472562e1fc79feec2d7203b15e443"}

[commit-bot: I haz the power, 2017-01-24 13:18:29]

Description was changed from

==========
[tubofan] teach escape analysis about ObjectIsNonCallable

R=mstarzinger@chromium.org, bmeurer@chromium.org

BUG=chromium:669242
==========

to

==========
[tubofan] teach escape analysis about ObjectIsNonCallable

R=mstarzinger@chromium.org, bmeurer@chromium.org

BUG=chromium:669242

Review-Url: https://codereview.chromium.org/2645273003
Cr-Commit-Position: refs/heads/master@{#42630}
Committed:
https://chromium.googlesource.com/v8/v8/+/e225251f256472562e1fc79feec2d7203b1...
==========

[commit-bot: I haz the power, 2017-01-24 13:18:30]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/e225251f256472562e1fc79feec2d7203b1...

[Michael Achenbach, 2017-01-26 22:29:44]

Note, there is an escape analysis error fired flakily since today, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build...

[Michael Achenbach, 2017-01-27 09:09:55]

On 2017/01/26 22:29:44, Michael Achenbach wrote:
> Note, there is an escape analysis error fired flakily since today, e.g.:
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build...

Bisected. Culprit seems to be this CL:
https://codereview.chromium.org/2638393002/

[Michael Starzinger, 2017-01-27 09:13:15]

On 2017/01/27 09:09:55, Michael Achenbach wrote:
> On 2017/01/26 22:29:44, Michael Achenbach wrote:
> > Note, there is an escape analysis error fired flakily since today, e.g.:
> >
>
https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20shared/build...
> 
> Bisected. Culprit seems to be this CL:
> https://codereview.chromium.org/2638393002/

Also note that ClusterFuzz has several repro cases for this assertion.