Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 2645233002: X87: [wasm] Fix codegen issue for i64.add and i64.sub on ia32. (Closed)

Created:
3 years, 11 months ago by zhengxing.li
Modified:
3 years, 11 months ago
Reviewers:
Eric Holk, chunyang.dai
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [wasm] Fix codegen issue for i64.add and i64.sub on ia32. port 037200e6250d5ea6fbd4f5071615c8c850e5a661 (r42486) original commit message: The IA32AddPair and IA32SubPair instructions were using an input register as a temporary value, which led to registers sometimes being clobbered when they shouldn't have been. This led to problems, for example, in calling printf to format doubles: printf("%f", 1.2345) => 0.61725 (on x86) BUG= Review-Url: https://codereview.chromium.org/2645233002 Cr-Commit-Position: refs/heads/master@{#42587} Committed: https://chromium.googlesource.com/v8/v8/+/8b5d1aa686a1966561493a9104dad37fbd5c46be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/compiler/x87/code-generator-x87.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
zhengxing.li
PTAL, thanks!
3 years, 11 months ago (2017-01-23 01:55:09 UTC) #2
chunyang.dai
On 2017/01/23 01:55:09, zhengxing.li wrote: > PTAL, thanks! LGTM. tanks
3 years, 11 months ago (2017-01-23 02:07:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645233002/1
3 years, 11 months ago (2017-01-23 02:30:28 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 02:51:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/8b5d1aa686a1966561493a9104dad37fbd5...

Powered by Google App Engine
This is Rietveld 408576698