Fix synchronization in SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Fix synchronization in SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600
Review-Url: https://codereview.chromium.org/2645203002
Cr-Commit-Position: refs/heads/master@{#445296}
Committed: https://chromium.googlesource.com/chromium/src/+/a8842cfaaca883d5f7b88504f4639e86f1368995

[wjmaclean, 2017-01-22 00:20:00]

Description was changed from

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

TBR=alexmos@chromium.org

BUG=683600
==========

to

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

TBR=creis@chromium.org

BUG=683600
==========

[wjmaclean, 2017-01-22 00:20:13]

wjmaclean@chromium.org changed reviewers:
+ creis@chromium.org
- alexmos@chromium.org

[wjmaclean, 2017-01-22 00:20:29]

The CQ bit was checked by wjmaclean@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-22 00:20:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[wjmaclean, 2017-01-22 00:49:34]

Description was changed from

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

TBR=creis@chromium.org

BUG=683600
==========

to

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600
==========

[commit-bot: I haz the power, 2017-01-22 01:02:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-22 01:02:55]

Dry run: This issue passed the CQ dry run.

[wjmaclean, 2017-01-22 01:03:16]

The CQ bit was checked by wjmaclean@chromium.org

[commit-bot: I haz the power, 2017-01-22 01:03:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-22 01:07:09]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485046996147120, "parent_rev":
"1d97062b110831423488e9bc5bd67a1bde1fded5", "commit_rev":
"a8842cfaaca883d5f7b88504f4639e86f1368995"}

[commit-bot: I haz the power, 2017-01-22 01:08:46]

Description was changed from

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600
==========

to

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600

Review-Url: https://codereview.chromium.org/2645203002
Cr-Commit-Position: refs/heads/master@{#445296}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8842cfaaca883d5f7b88504f463...
==========

[commit-bot: I haz the power, 2017-01-22 01:08:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a8842cfaaca883d5f7b88504f463...

[Charlie Reis, 2017-01-23 19:38:49]

LGTM.  Don't forget to still publish the CL when you use TBR.  :)  (I saw your
chat message about it but didn't get an email.)

[Charlie Reis, 2017-01-23 19:39:08]

Description was changed from

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600

Review-Url: https://codereview.chromium.org/2645203002
Cr-Commit-Position: refs/heads/master@{#445296}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8842cfaaca883d5f7b88504f463...
==========

to

==========
Fix synchronization in
SitePerProcessTextInputManagerTest.SubframeKeyboardEditCommands.

Keyboard events in some tests have been assumed to be synchronous
with ExecuteScript commands, but that assumption is no longer
valid with OOPIFs getting their own InputHandlers in
https://codereview.chromium.org/2479663002/.

TBR=creis@chromium.org

BUG=683600

Review-Url: https://codereview.chromium.org/2645203002
Cr-Commit-Position: refs/heads/master@{#445296}
Committed:
https://chromium.googlesource.com/chromium/src/+/a8842cfaaca883d5f7b88504f463...
==========

[wjmaclean, 2017-01-23 20:48:55]

On 2017/01/23 19:38:49, Charlie Reis wrote:
> LGTM.  Don't forget to still publish the CL when you use TBR.  :)  (I saw your
> chat message about it but didn't get an email.)

Ooops, sorry ... I really, really try to avoid overusing TBRs, so when I do I
forget about that part ... will do my best to remember next time.