Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 2645153003: Convert ExtensionSettingsHandler to use the new navigation callbacks. (Closed)

Created:
3 years, 11 months ago by jam
Modified:
3 years, 11 months ago
Reviewers:
Devlin
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ExtensionSettingsHandler to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2645153003 Cr-Commit-Position: refs/heads/master@{#445558} Committed: https://chromium.googlesource.com/chromium/src/+/8e19fe1c7b15b56ec39e5b395b23b3ff34afb579

Patch Set 1 #

Patch Set 2 : review comment #

Patch Set 3 : use GetReloadType #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M chrome/browser/ui/webui/extensions/extension_settings_handler.h View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 2 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 23 (17 generated)
jam
3 years, 11 months ago (2017-01-21 00:43:25 UTC) #5
Devlin
(same questions as https://codereview.chromium.org/2648803002/)
3 years, 11 months ago (2017-01-21 02:04:14 UTC) #8
jam
ptal
3 years, 11 months ago (2017-01-23 23:46:09 UTC) #17
Devlin
lgtm
3 years, 11 months ago (2017-01-24 00:02:55 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645153003/40001
3 years, 11 months ago (2017-01-24 00:16:47 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 00:25:08 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8e19fe1c7b15b56ec39e5b395b23...

Powered by Google App Engine
This is Rietveld 408576698