|
|
DescriptionDisable all GPU on Linux Mesa driver 10.1.3 or older.
This driver is reported to render incorrectly and crash. The most common crash
is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening
on multiple GPU vendors and types with this driver version.
R=zmo@chromium.org
BUG=629434
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Review-Url: https://codereview.chromium.org/2645123003
Cr-Commit-Position: refs/heads/master@{#452622}
Committed: https://chromium.googlesource.com/chromium/src/+/f747b99b3a9c6ddac3470d61d3f292a019e1c1c2
Patch Set 1 #Patch Set 2 : Expand to all vendors. #Patch Set 3 : Exclode osmesa from blacklist. #Patch Set 4 : Rebase. #Patch Set 5 : Fix osmesa rule exception. Remove GpuProcess_software_gpu_process test. #
Messages
Total messages: 36 (30 generated)
Description was changed from ========== Disable all GPU support for AMD on Mesa driver 10.1.3 or older. R=zmo@chromium.org BUG=629434 ========== to ========== Disable all GPU support for AMD on Mesa driver 10.1.3 or older. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
PTAL. Mesa version 10.1.3 accounts for over 99% of crashes with signature gpu::gles2::GLES2DecoderImpl::HandleReadPixels, on multiple vendors and device ids.
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Disable all GPU support for AMD on Mesa driver 10.1.3 or older. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
LGTM With this entry, we can actually clean up a bunch of older entries that turn off features on older mesa
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...) android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...) mac_optional_gpu_tests_rel on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by vmiura@chromium.org to run a CQ dry run
vmiura@chromium.org changed reviewers: + kbr@chromium.org
kbr@ would you mind taking a quick look at these changes?
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
LGTM. The old test was not useful. Tests higher up in the file already covered entries in software_rendering_list_json.cc.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by vmiura@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2645123003/#ps80001 (title: "Fix osmesa rule exception. Remove GpuProcess_software_gpu_process test.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch. Bot data: {"patchset_id": 80001, "attempt_start_ts": 1487879029938900, "parent_rev": "a3fa1a521a96b8c1fb63d1e7cc0d2cc3ee5028d9", "commit_rev": "f747b99b3a9c6ddac3470d61d3f292a019e1c1c2"}
Message was sent while issue was closed.
Description was changed from ========== Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2645123003 Cr-Commit-Position: refs/heads/master@{#452622} Committed: https://chromium.googlesource.com/chromium/src/+/f747b99b3a9c6ddac3470d61d3f2... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/chromium/src/+/f747b99b3a9c6ddac3470d61d3f2... |