Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 2645123003: Disable all GPU support on Linux Mesa driver 10.1.3 or older. (Closed)

Created:
3 years, 11 months ago by vmiura
Modified:
3 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable all GPU on Linux Mesa driver 10.1.3 or older. This driver is reported to render incorrectly and crash. The most common crash is in gpu::gles2::GLES2DecoderImpl::HandleReadPixels, and is happening on multiple GPU vendors and types with this driver version. R=zmo@chromium.org BUG=629434 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2645123003 Cr-Commit-Position: refs/heads/master@{#452622} Committed: https://chromium.googlesource.com/chromium/src/+/f747b99b3a9c6ddac3470d61d3f292a019e1c1c2

Patch Set 1 #

Patch Set 2 : Expand to all vendors. #

Patch Set 3 : Exclode osmesa from blacklist. #

Patch Set 4 : Rebase. #

Patch Set 5 : Fix osmesa rule exception. Remove GpuProcess_software_gpu_process test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M content/test/gpu/gpu_tests/gpu_process_integration_test.py View 1 2 3 4 2 chunks +1 line, -13 lines 0 comments Download
M gpu/config/software_rendering_list_json.cc View 1 2 3 4 4 chunks +26 lines, -22 lines 0 comments Download

Messages

Total messages: 36 (30 generated)
vmiura
PTAL. Mesa version 10.1.3 accounts for over 99% of crashes with signature gpu::gles2::GLES2DecoderImpl::HandleReadPixels, on multiple ...
3 years, 11 months ago (2017-01-21 04:35:33 UTC) #4
Zhenyao Mo
LGTM With this entry, we can actually clean up a bunch of older entries that ...
3 years, 11 months ago (2017-01-23 18:39:40 UTC) #10
vmiura
kbr@ would you mind taking a quick look at these changes?
3 years, 10 months ago (2017-02-18 00:20:27 UTC) #26
Ken Russell (switch to Gerrit)
LGTM. The old test was not useful. Tests higher up in the file already covered ...
3 years, 10 months ago (2017-02-18 00:27:59 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645123003/80001
3 years, 10 months ago (2017-02-23 19:44:29 UTC) #33
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 20:56:59 UTC) #36
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/f747b99b3a9c6ddac3470d61d3f2...

Powered by Google App Engine
This is Rietveld 408576698