Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2645123002:
[spellcheck] Re-enable Windows tests (Closed)
|
Created:
3 years, 11 months ago by Kevin Bailey Modified:
3 years, 11 months ago Reviewers:
groby-ooo-7-16 CC:
chromium-reviews, groby+spellwatch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, timvolodine Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRe-enable tests that timed-out on Windows (and one suspicious failure).
BUG=678753, 679549, 678300
Review-Url: https://codereview.chromium.org/2645123002
Cr-Commit-Position: refs/heads/master@{#446024}
Committed: https://chromium.googlesource.com/chromium/src/+/e2af7dcc6bf1147b230fe27a4487aeace6f315d3
Patch Set 1 #Patch Set 2 : Corrected ifdef usage #Patch Set 3 : Forgot comment #
Total comments: 1
Patch Set 4 : Re-enable TSAN test as well #Patch Set 5 : Try without TSAN #Patch Set 6 : Re-try TSAN with fixed CQs #Messages
Total messages: 28 (20 generated)
Description was changed from ========== Trying to re-enable some tests BUG= ========== to ========== Re-enable tests that timed-out on Windows (and one suspicious failure). BUG=678753,679549,678300 ==========
krb@chromium.org changed reviewers: + groby@chromium.org
The Win bots seem to be happy with the restored tests. I've run both rel and dbg a couple times.
lgtm https://codereview.chromium.org/2645123002/diff/40001/components/spellcheck/r... File components/spellcheck/renderer/spellcheck_unittest.cc (right): https://codereview.chromium.org/2645123002/diff/40001/components/spellcheck/r... components/spellcheck/renderer/spellcheck_unittest.cc:492: #if defined(THREAD_SANITIZER) Once this has landed, could you give this another try under TSAN as well?
The CQ bit was checked by krb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org Link to the patchset: https://codereview.chromium.org/2645123002/#ps60001 (title: "Re-enable TSAN test as well")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
The CQ bit was checked by krb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org Link to the patchset: https://codereview.chromium.org/2645123002/#ps80001 (title: "Try without TSAN")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by krb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by krb@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by krb@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org Link to the patchset: https://codereview.chromium.org/2645123002/#ps100001 (title: "Re-try TSAN with fixed CQs")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 100001, "attempt_start_ts": 1485357983877900,
"parent_rev": "e5fd75af8171718a84d387486cfba0ed225c6f5f", "commit_rev":
"e2af7dcc6bf1147b230fe27a4487aeace6f315d3"}
Message was sent while issue was closed.
Description was changed from ========== Re-enable tests that timed-out on Windows (and one suspicious failure). BUG=678753,679549,678300 ========== to ========== Re-enable tests that timed-out on Windows (and one suspicious failure). BUG=678753,679549,678300 Review-Url: https://codereview.chromium.org/2645123002 Cr-Commit-Position: refs/heads/master@{#446024} Committed: https://chromium.googlesource.com/chromium/src/+/e2af7dcc6bf1147b230fe27a4487... ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as https://chromium.googlesource.com/chromium/src/+/e2af7dcc6bf1147b230fe27a4487... |
