Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(610)

Issue 2645063002: includes: move Label out of assembler.h. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com, rmcilroy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

includes: move Label out of assembler.h. E.g., ast/ast.h uses Label but shouldn't need to include assembler.h for that. With this change, we can hope for proper layering in the future (not quite there yet). Also includes minor random include lowering and relevant IWYU fixes. BUG=v8:5294 Review-Url: https://codereview.chromium.org/2645063002 Cr-Commit-Position: refs/heads/master@{#42563} Committed: https://chromium.googlesource.com/v8/v8/+/226e454069c78c4197f951b5d5d822fb412ab7e0

Patch Set 1 #

Patch Set 2 : oops #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -86 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M src/assembler.h View 2 chunks +1 line, -73 lines 0 comments Download
M src/assembler.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/ast/ast.h View 2 chunks +1 line, -1 line 0 comments Download
M src/ast/ast-value-factory.h View 1 chunk +2 lines, -1 line 0 comments Download
A src/label.h View 1 1 chunk +92 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/interpreter/interpreter-tester.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
marja
mstarzinger, ptal
3 years, 11 months ago (2017-01-20 13:25:36 UTC) #2
Michael Starzinger
You forgot to add the label.h file to this CL.
3 years, 11 months ago (2017-01-20 13:26:33 UTC) #3
marja
oops, added
3 years, 11 months ago (2017-01-20 13:28:26 UTC) #4
Michael Starzinger
LGTM.
3 years, 11 months ago (2017-01-20 13:33:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645063002/20001
3 years, 11 months ago (2017-01-20 13:34:11 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 14:21:39 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/226e454069c78c4197f951b5d5d822fb412...

Powered by Google App Engine
This is Rietveld 408576698