Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 2645043004: Migrate expensive referrer CHECK to DCHECK in FrameFetchContext (Closed)

Created:
3 years, 11 months ago by Charlie Harrison
Modified:
3 years, 11 months ago
CC:
blink-reviews, chromium-reviews, gavinp+loader_chromium.org, Nate Chapin, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Yoav Weiss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate expensive referrer CHECK to DCHECK in FrameFetchContext Profiles on linux show this accounts for ~3.5% of the CPU cost of requesting a resource. This check is important for security, but as jochen@ notes in the linked bug, we do the check in the network stack as well. BUG=683319 Review-Url: https://codereview.chromium.org/2645043004 Cr-Commit-Position: refs/heads/master@{#445386} Committed: https://chromium.googlesource.com/chromium/src/+/7f2447403881449544e449c595cad4287b835971

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/loader/FrameFetchContext.cpp View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Charlie Harrison
jochen: PTAL? Thanks for your quick response on the bug.
3 years, 11 months ago (2017-01-20 20:16:41 UTC) #3
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-23 08:33:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645043004/1
3 years, 11 months ago (2017-01-23 12:55:36 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 16:33:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/7f2447403881449544e449c595ca...

Powered by Google App Engine
This is Rietveld 408576698