Use InitializeBlinkFuzzTest instead of ScopedUnittestsEnvironmentSetup.

Use InitializeBlinkFuzzTest instead of ScopedUnittestsEnvironmentSetup.

Since r443701, DEFINE_STATIC_LOCAL cannot be used until threading is
initialized.  This CL stops using DEFINE_STATIC_LOCAL and
ScopedUnittestsEnvironmentSetup from MHTMLFuzzer.cpp and instead uses
the initialization helper used by all the other fuzzers -
InitializeBlinkFuzzTest.

BUG=681290
Review-Url: https://codereview.chromium.org/2645043003
Cr-Commit-Position: refs/heads/master@{#445438}
Committed: https://chromium.googlesource.com/chromium/src/+/608d39b1e2e2666c2a37512452be51309709362e

[Łukasz Anforowicz, 2017-01-20 20:00:51]

lukasza@chromium.org changed reviewers:
+ haraken@chromium.org

[Łukasz Anforowicz, 2017-01-20 20:00:51]

haraken@, could you PTAL?

This CL fixes the crash from https://crbug.com/681290, but please speak up if
you think we should do something else wrt to structuring test initialization. 
In particular, this CL leaves ScopedUnittestsEnvironmentSetup untouched and
still used by RunAllTests.cpp (even though this code is no longer shared by
RunAllTests.cpp and MHTMLFuzzer.cpp).

[Charlie Harrison, 2017-01-20 20:03:00]

csharrison@chromium.org changed reviewers:
+ csharrison@chromium.org

[Charlie Harrison, 2017-01-20 20:03:00]

I'm also curious if haraken@ has opposition to the new restriction on
DEFINE_STATIC_LOCAL. It can be re-written to not rely on the new thread local
storage threading helpers (and just use syscalls to determine the current
thread).

[haraken, 2017-01-23 00:12:34]

On 2017/01/20 20:03:00, Charlie Harrison wrote:
> I'm also curious if haraken@ has opposition to the new restriction on
> DEFINE_STATIC_LOCAL. It can be re-written to not rely on the new thread local
> storage threading helpers (and just use syscalls to determine the current
> thread).

Yeah, it would be better if we could remove the restriction from
DEFINE_STATIC_LOCAL :)

[Charlie Harrison, 2017-01-23 02:21:09]

SGTM, I will fix that separately. FWIW I think this is still a worthwhile patch
even with that fixed separately.

[haraken, 2017-01-23 02:27:47]

On 2017/01/23 02:21:09, Charlie Harrison wrote:
> SGTM, I will fix that separately. FWIW I think this is still a worthwhile
patch
> even with that fixed separately.

Yes, LGTM

[Łukasz Anforowicz, 2017-01-23 16:47:11]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-23 16:47:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 17:36:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 17:36:35]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, no build
URL)

[Łukasz Anforowicz, 2017-01-23 17:57:02]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2017-01-23 17:57:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 19:45:57]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1485194222238620, "parent_rev":
"b257ac3cf4858f2fb77fab58737dcf6bc3d3ca5a", "commit_rev":
"608d39b1e2e2666c2a37512452be51309709362e"}

[commit-bot: I haz the power, 2017-01-23 19:46:28]

Description was changed from

==========
Use InitializeBlinkFuzzTest instead of ScopedUnittestsEnvironmentSetup.

Since r443701, DEFINE_STATIC_LOCAL cannot be used until threading is
initialized.  This CL stops using DEFINE_STATIC_LOCAL and
ScopedUnittestsEnvironmentSetup from MHTMLFuzzer.cpp and instead uses
the initialization helper used by all the other fuzzers -
InitializeBlinkFuzzTest.

BUG=681290
==========

to

==========
Use InitializeBlinkFuzzTest instead of ScopedUnittestsEnvironmentSetup.

Since r443701, DEFINE_STATIC_LOCAL cannot be used until threading is
initialized.  This CL stops using DEFINE_STATIC_LOCAL and
ScopedUnittestsEnvironmentSetup from MHTMLFuzzer.cpp and instead uses
the initialization helper used by all the other fuzzers -
InitializeBlinkFuzzTest.

BUG=681290

Review-Url: https://codereview.chromium.org/2645043003
Cr-Commit-Position: refs/heads/master@{#445438}
Committed:
https://chromium.googlesource.com/chromium/src/+/608d39b1e2e2666c2a37512452be...
==========

[commit-bot: I haz the power, 2017-01-23 19:46:29]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/608d39b1e2e2666c2a37512452be...