Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2645003002: Remove ScopedVector in //components/bookmarks (Closed)

Created:
3 years, 11 months ago by ke.he
Modified:
3 years, 11 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector in //components/bookmarks BUG=554289 Review-Url: https://codereview.chromium.org/2645003002 Cr-Commit-Position: refs/heads/master@{#445298} Committed: https://chromium.googlesource.com/chromium/src/+/41fc7f62641a7c5f84273880fcb846ed17b55f2f

Patch Set 1 : Remove ScopedVector in //components/bookmarks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M components/bookmarks/managed/managed_bookmark_service.cc View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 17 (13 generated)
ke.he
Hi, Sky@, Could you PTAL? Thanks very much.
3 years, 11 months ago (2017-01-20 06:25:16 UTC) #9
sky
LGTM
3 years, 11 months ago (2017-01-20 17:20:48 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2645003002/20001
3 years, 11 months ago (2017-01-22 02:48:46 UTC) #14
commit-bot: I haz the power
3 years, 11 months ago (2017-01-22 03:35:08 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/41fc7f62641a7c5f84273880fcb8...

Powered by Google App Engine
This is Rietveld 408576698