Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2644993002:
[wasm] WebAssembly.instantiate has a pair-returning overload (Closed)
|
Created:
3 years, 11 months ago by Mircea Trofin Modified:
3 years, 11 months ago CC:
v8-reviews_googlegroups.com, Derek Schuff Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[wasm] WebAssembly.instantiate has a pair-returning overload
Additionally, fixed invalid check in WebAssembly.Module constructor.
The constructor takes precisely one argument.
BUG=v8:5875
Review-Url: https://codereview.chromium.org/2644993002
Cr-Commit-Position: refs/heads/master@{#42575}
Committed: https://chromium.googlesource.com/v8/v8/+/24c050e8bc7f6e954a0de532a4cc2872d121ceb5
Patch Set 1 #Patch Set 2 : tests #
Total comments: 4
Patch Set 3 : feedback #
Messages
Total messages: 22 (16 generated)
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [wasm] WebAssembly.instantiate has a pair-returning overload BUG= ========== to ========== [wasm] WebAssembly.instantiate has a pair-returning overload BUG=v8:5875 ==========
mtrofin@chromium.org changed reviewers: + bradnelson@chromium.org, rossberg@chromium.org, titzer@chromium.org
Description was changed from ========== [wasm] WebAssembly.instantiate has a pair-returning overload BUG=v8:5875 ========== to ========== [wasm] WebAssembly.instantiate has a pair-returning overload Additionally, fixed invalid check in WebAssembly.Module constructor. The constructor takes precisely one argument. BUG=v8:5875 ==========
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
I completely missed that instantiate had an overload.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2644993002/diff/20001/src/wasm/wasm-js.cc File src/wasm/wasm-js.cc (right): https://codereview.chromium.org/2644993002/diff/20001/src/wasm/wasm-js.cc#new... src/wasm/wasm-js.cc:183: if (args.Length() != 1) { JavaScript always allows unused extra arguments, so this actually is incorrect (and was before). Just leave the condition as is and delete the other `if`. https://codereview.chromium.org/2644993002/diff/20001/test/mjsunit/wasm/js-ap... File test/mjsunit/wasm/js-api.js (right): https://codereview.chromium.org/2644993002/diff/20001/test/mjsunit/wasm/js-ap... test/mjsunit/wasm/js-api.js:635: assertEq(result.module instanceof Module, true); Nit: Using assertTrue would make this less redundant.
https://codereview.chromium.org/2644993002/diff/20001/src/wasm/wasm-js.cc File src/wasm/wasm-js.cc (right): https://codereview.chromium.org/2644993002/diff/20001/src/wasm/wasm-js.cc#new... src/wasm/wasm-js.cc:183: if (args.Length() != 1) { On 2017/01/20 09:56:54, rossberg wrote: > JavaScript always allows unused extra arguments, so this actually is incorrect > (and was before). Just leave the condition as is and delete the other `if`. Done. https://codereview.chromium.org/2644993002/diff/20001/test/mjsunit/wasm/js-ap... File test/mjsunit/wasm/js-api.js (right): https://codereview.chromium.org/2644993002/diff/20001/test/mjsunit/wasm/js-ap... test/mjsunit/wasm/js-api.js:635: assertEq(result.module instanceof Module, true); On 2017/01/20 09:56:54, rossberg wrote: > Nit: Using assertTrue would make this less redundant. Done, and fixed everywhere else, too.
The CQ bit was checked by mtrofin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bradnelson@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484937419857430,
"parent_rev": "a5b89e21461789a1304c935844005f8ce284fa6a", "commit_rev":
"24c050e8bc7f6e954a0de532a4cc2872d121ceb5"}
Message was sent while issue was closed.
Description was changed from ========== [wasm] WebAssembly.instantiate has a pair-returning overload Additionally, fixed invalid check in WebAssembly.Module constructor. The constructor takes precisely one argument. BUG=v8:5875 ========== to ========== [wasm] WebAssembly.instantiate has a pair-returning overload Additionally, fixed invalid check in WebAssembly.Module constructor. The constructor takes precisely one argument. BUG=v8:5875 Review-Url: https://codereview.chromium.org/2644993002 Cr-Commit-Position: refs/heads/master@{#42575} Committed: https://chromium.googlesource.com/v8/v8/+/24c050e8bc7f6e954a0de532a4cc2872d12... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/24c050e8bc7f6e954a0de532a4cc2872d12... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
