Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(494)

Issue 2644983002: Scale bounds from dip to pixels in CompositorFrame in content::MusBrowserCompositorOutputSurface. (Closed)

Created:
3 years, 11 months ago by riajiang
Modified:
3 years, 11 months ago
Reviewers:
sadrul, sky
CC:
chromium-reviews, jam, jbauman+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, kylechar
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Scale bounds from dip to pixels in CompositorFrame in content::MusBrowserCompositorOutputSurface since CompositorFrames we submit to the display-manager need to be in physical pixel-space. BUG=680982 TEST=manual (--force-device-scale-factor=2) Review-Url: https://codereview.chromium.org/2644983002 Cr-Commit-Position: refs/heads/master@{#445137} Committed: https://chromium.googlesource.com/chromium/src/+/5ab7d1bfe8bf1024ea1459002c179a8cd24f6f29

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M content/browser/compositor/mus_browser_compositor_output_surface.cc View 3 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
riajiang
Hi sadrul@ and sky@, both browser and renderer show up correctly after this change. I ...
3 years, 11 months ago (2017-01-20 03:01:20 UTC) #5
sky
LGTM but but I'm not an owner. Sadrul is though. Thanks for tracking this down!
3 years, 11 months ago (2017-01-20 16:42:19 UTC) #8
sadrul
lgtm
3 years, 11 months ago (2017-01-20 19:11:26 UTC) #9
sadrul
Can you update the CL desc. to say that CompositorFrames we submit to the display-manager ...
3 years, 11 months ago (2017-01-20 19:12:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644983002/1
3 years, 11 months ago (2017-01-20 19:41:40 UTC) #13
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 19:46:11 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5ab7d1bfe8bf1024ea1459002c17...

Powered by Google App Engine
This is Rietveld 408576698