Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 2644953003: Files app: Add new FSP providers to the reporting whitelist. (Closed)

Created:
3 years, 11 months ago by fukino
Modified:
3 years, 11 months ago
Reviewers:
Steve McKay
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org, zentaro
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Files app: Add new FSP providers to the reporting whitelist. BUG=682744 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2644953003 Cr-Commit-Position: refs/heads/master@{#444861} Committed: https://chromium.googlesource.com/chromium/src/+/8faae2abff3afc7c7a0a781d7135bf128cfc718b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/file_manager/file_manager/common/js/metrics_events.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (5 generated)
fukino
PTAL
3 years, 11 months ago (2017-01-19 21:27:10 UTC) #3
Steve McKay
lgtm
3 years, 11 months ago (2017-01-19 21:37:34 UTC) #4
fukino
Thanks!
3 years, 11 months ago (2017-01-19 21:46:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644953003/1
3 years, 11 months ago (2017-01-19 21:47:16 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 22:20:23 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8faae2abff3afc7c7a0a781d7135...

Powered by Google App Engine
This is Rietveld 408576698