Issue 2644953002: Store a file state in the incremental resolved AST generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2644953002: Store a file state in the incremental resolved AST generator. (Closed)

Created:
3 years, 11 months ago by Paul Berry

Modified:
3 years, 11 months ago

Reviewers:
danrubel

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Store a file state in the incremental resolved AST generator. This is necessary to make invalidation work properly. It also ensures that we don't do redundant reads from the filesystem. R=danrubel@google.com Committed: https://github.com/dart-lang/sdk/commit/6acc2c26113c187526a9014de7c59ca7e3c83c44

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -27 lines)			Patch
M	pkg/front_end/lib/src/base/file_repository.dart	View		1 chunk	+26 lines, -1 line	0 comments	Download
M	pkg/front_end/lib/src/dependency_grapher_impl.dart	View		4 chunks	+15 lines, -8 lines	0 comments	Download
M	pkg/front_end/lib/src/incremental_resolved_ast_generator_impl.dart	View		4 chunks	+16 lines, -7 lines	0 comments	Download
M	pkg/front_end/test/incremental_resolved_ast_generator_test.dart	View	1	1 chunk	+6 lines, -3 lines	0 comments	Download
M	pkg/front_end/test/src/base/file_repository_test.dart	View		3 chunks	+10 lines, -8 lines	0 comments	Download

Total messages: 5 (2 generated)

Paul Berry

3 years, 11 months ago (2017-01-19 21:59:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
6acc2c26113c187526a9014de7c59ca7e3c83c44 (presubmit successful).