Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: pkg/front_end/test/incremental_resolved_ast_generator_test.dart

Issue 2644953002: Store a file state in the incremental resolved AST generator. (Closed)
Patch Set: Additional testing logic Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/test/incremental_resolved_ast_generator_test.dart
diff --git a/pkg/front_end/test/incremental_resolved_ast_generator_test.dart b/pkg/front_end/test/incremental_resolved_ast_generator_test.dart
index 6e1e4450ae83685d4f69c8b09ba2dbc9df5b5cc7..553c9f383179b674961bd166d7522ee63001f98d 100644
--- a/pkg/front_end/test/incremental_resolved_ast_generator_test.dart
+++ b/pkg/front_end/test/incremental_resolved_ast_generator_test.dart
@@ -70,10 +70,13 @@ class IncrementalResolvedAstGeneratorTest {
_checkMain(initialProgram[fooUri].definingCompilationUnit, 1);
writeFiles({'/foo.dart': 'main() { print(2); }'});
- // TODO(paulberry): verify that the file isn't actually reread until
- // invalidate is called.
- // var deltaProgram1 = await incrementalResolvedAstGenerator.computeDelta();
+ // Verify that the file isn't actually reread until invalidate is called.
+ var deltaProgram1 = await incrementalResolvedAstGenerator.computeDelta();
+ // TODO(paulberry): since there is no delta, computeDelta should return an
+ // empty map.
// expect(deltaProgram1.newState, isEmpty);
+ expect(deltaProgram1.newState.keys, unorderedEquals([fooUri]));
+ _checkMain(deltaProgram1.newState[fooUri].definingCompilationUnit, 1);
incrementalResolvedAstGenerator.invalidateAll();
var deltaProgram2 = await incrementalResolvedAstGenerator.computeDelta();
expect(deltaProgram2.newState.keys, unorderedEquals([fooUri]));

Powered by Google App Engine
This is Rietveld 408576698