Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2644933005: Fix google.com rendering: UpdatePosition for descendants (Closed)

Created:
3 years, 11 months ago by atotic
Modified:
3 years, 11 months ago
Reviewers:
cbiesinger
CC:
atotic+reviews_chromium.org, blink-reviews, blink-reviews-layout_chromium.org, cbiesinger, chromium-reviews, dgrogan+ng_chromium.org, eae+blinkwatch, glebl+reviews_chromium.org, jchaffraix+rendering, leviw+renderwatch, ojan+watch_chromium.org, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix google.com rendering: UpdatePosition for descendants I had to touch LayoutOutOfFlowChild, so I also ripped out old state-related stuff. BUG=635619 Review-Url: https://codereview.chromium.org/2644933005 Cr-Commit-Position: refs/heads/master@{#445244} Committed: https://chromium.googlesource.com/chromium/src/+/e100229f582a151b27bfe1d1bd85942b5b7d05e8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -41 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.h View 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc View 4 chunks +32 lines, -32 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_block_node.h View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
atotic
ptal
3 years, 11 months ago (2017-01-20 22:55:47 UTC) #2
cbiesinger
lgtm
3 years, 11 months ago (2017-01-21 00:06:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644933005/1
3 years, 11 months ago (2017-01-21 00:14:44 UTC) #6
commit-bot: I haz the power
3 years, 11 months ago (2017-01-21 01:37:27 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e100229f582a151b27bfe1d1bd85...

Powered by Google App Engine
This is Rietveld 408576698