[TTS] Fix a test that's failing with PlzNavigate enabled.

[TTS] Fix a test that's failing with PlzNavigate enabled.

Fix ContextualSearchManagerTest_testPrefetchFailoverRequestMadeAfterOpen
failing with PlzNavigate.  When we simulate a navigation failure we
follow that with a call to stop navigation.  This causes
NavigationHandleImpl::GetPageTransition to fail an assert because
the navigation has not actually started yet, due to the way we
partially fake navigation in tests.

This CL vectors stopping the navigation through our NetworkCommunicator,
since network control actions should not run live in tests.

BUG=674303
Review-Url: https://codereview.chromium.org/2644933002
Cr-Commit-Position: refs/heads/master@{#444860}
Committed: https://chromium.googlesource.com/chromium/src/+/51787340a7c9f2c1c84a522f7dc8ac0b4025440f

[Donn Denman, 2017-01-19 19:14:57]

The CQ bit was checked by donnd@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 19:15:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 20:39:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 20:39:51]

Dry run: This issue passed the CQ dry run.

[Donn Denman, 2017-01-19 21:08:17]

donnd@chromium.org changed reviewers:
+ twellington@chromium.org

[Donn Denman, 2017-01-19 21:08:17]

Theresa, PTAL.  Thanks!

[Theresa, 2017-01-19 21:15:06]

lgtm % nit

https://codereview.chromium.org/2644933002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
(right):

https://codereview.chromium.org/2644933002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java:56:
* Stops any navigation in the overlay panel's {@code WebContents}.
nit: {@link WebContents}?

[Donn Denman, 2017-01-19 21:42:00]

Thanks Theresa!

https://codereview.chromium.org/2644933002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java
(right):

https://codereview.chromium.org/2644933002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchNetworkCommunicator.java:56:
* Stops any navigation in the overlay panel's {@code WebContents}.
On 2017/01/19 21:15:06, Theresa wrote:
> nit: {@link WebContents}?

Decided to leave this unchanged.  I used @code instead of @link because
WebContents is not included in this file so I think the @link will not know
where to link to.  It looks like it's possible to use a fully-qualified name
here, but the whole thing seems like overkill to me -- I think all readers of
this code know what WebContents is, and where to find it.

[Donn Denman, 2017-01-19 21:42:13]

The CQ bit was checked by donnd@chromium.org

[Donn Denman, 2017-01-19 21:42:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
twellington@chromium.org
Link to the patchset: https://codereview.chromium.org/2644933002/#ps40001
(title: "Decided to change back to @code in the comment.")

[commit-bot: I haz the power, 2017-01-19 21:42:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 22:18:41]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484862133408250,
"parent_rev": "485df9ed214f7924eaf8ed067070146e3d12aa58", "commit_rev":
"51787340a7c9f2c1c84a522f7dc8ac0b4025440f"}

[commit-bot: I haz the power, 2017-01-19 22:19:14]

Description was changed from

==========
[TTS] Fix a test that's failing with PlzNavigate enabled.

Fix ContextualSearchManagerTest_testPrefetchFailoverRequestMadeAfterOpen
failing with PlzNavigate.  When we simulate a navigation failure we
follow that with a call to stop navigation.  This causes
NavigationHandleImpl::GetPageTransition to fail an assert because
the navigation has not actually started yet, due to the way we
partially fake navigation in tests.

This CL vectors stopping the navigation through our NetworkCommunicator,
since network control actions should not run live in tests.

BUG=674303
==========

to

==========
[TTS] Fix a test that's failing with PlzNavigate enabled.

Fix ContextualSearchManagerTest_testPrefetchFailoverRequestMadeAfterOpen
failing with PlzNavigate.  When we simulate a navigation failure we
follow that with a call to stop navigation.  This causes
NavigationHandleImpl::GetPageTransition to fail an assert because
the navigation has not actually started yet, due to the way we
partially fake navigation in tests.

This CL vectors stopping the navigation through our NetworkCommunicator,
since network control actions should not run live in tests.

BUG=674303

Review-Url: https://codereview.chromium.org/2644933002
Cr-Commit-Position: refs/heads/master@{#444860}
Committed:
https://chromium.googlesource.com/chromium/src/+/51787340a7c9f2c1c84a522f7dc8...
==========

[commit-bot: I haz the power, 2017-01-19 22:19:14]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/51787340a7c9f2c1c84a522f7dc8...