Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2644893004: [wasm] WebAssembly.compile: pass errors through promise resolver (Closed)

Created:
3 years, 11 months ago by Mircea Trofin
Modified:
3 years, 11 months ago
Reviewers:
titzer, bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] WebAssembly.compile: pass errors through promise resolver BUG=v8:5876 Review-Url: https://codereview.chromium.org/2644893004 Cr-Commit-Position: refs/heads/master@{#42568} Committed: https://chromium.googlesource.com/v8/v8/+/2e3447bb665558b87f44c85750764cb62d0cb42f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M src/wasm/wasm-js.cc View 1 chunk +7 lines, -5 lines 0 comments Download
M test/mjsunit/wasm/js-api.js View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 12 (9 generated)
rossberg
lgtm
3 years, 11 months ago (2017-01-20 10:57:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644893004/1
3 years, 11 months ago (2017-01-20 15:32:03 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 15:34:04 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/2e3447bb665558b87f44c85750764cb62d0...

Powered by Google App Engine
This is Rietveld 408576698