Unify Preferences Mojom Naming to PreferencesService

Unify Preferences Mojom Naming to PreferencesService

Renaming:
PreferencesManager  - PreferencesService
PreferencesFactory  - PreferencesServiceFactory
PreferencesObserver - PreferencesServiceClient

Updated associated usage of manager/observer in code to service/client.
Updated PrefObserverStore to PrefClientStore.

TEST=manual, preferences_unittests, unit_tests
BUG=674138
Review-Url: https://codereview.chromium.org/2644893003
Cr-Commit-Position: refs/heads/master@{#449796}
Committed: https://chromium.googlesource.com/chromium/src/+/0fce105a2049f924de6c4d7dc416ba8775125bb8

[jonross, 2017-01-25 18:38:50]

jonross@chromium.org changed reviewers:
+ sky@chromium.org

[jonross, 2017-01-25 18:38:51]

Hey sky@,

This was a proposed renaming for preferences. Could you take a look at ash/ and
chrome/

Thanks,
Jon

[sky, 2017-01-25 21:50:01]

LGTM

[jonross, 2017-01-25 21:50:59]

jonross@chromium.org changed reviewers:
+ ben@chromium.org

[jonross, 2017-01-25 21:50:59]

Hey Ben,

This is the mojom rename you suggested for preferences.

Could you review the changes in services/?

Thanks,
Jon

[jonross, 2017-02-07 18:37:44]

Hey Ben,

This is the mojom rename you suggested for preferences.

Could you review the changes in services/?

Thank

[Ben Goodger (Google), 2017-02-08 03:29:41]

lgtm

[jonross, 2017-02-08 14:44:18]

jonross@chromium.org changed reviewers:
+ dcheng@chromium.org

[jonross, 2017-02-08 14:44:19]

Hey dcheng@,

We had previously discussed renaming of PreferencesObserver to a client, since
we have a 1-1 relationship between it and its manager.

This change implements a full renaming of the mojom. Could you provide the
security review for the updated mojom interface?

Thanks,
Jon

[dcheng, 2017-02-10 22:42:12]

rs lgtm for mojom

(sorry for missing this CL, please feel free to ping more aggressively in the
future)

[jonross, 2017-02-10 22:55:08]

The CQ bit was checked by jonross@chromium.org

[commit-bot: I haz the power, 2017-02-10 22:55:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-11 00:05:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486767308164340,
"parent_rev": "cfa9dd423a171356f71478605f903b6410fe7861", "commit_rev":
"0fce105a2049f924de6c4d7dc416ba8775125bb8"}

[commit-bot: I haz the power, 2017-02-11 00:05:51]

Description was changed from

==========
Unify Preferences Mojom Naming to PreferencesService

Renaming:
PreferencesManager  - PreferencesService
PreferencesFactory  - PreferencesServiceFactory
PreferencesObserver - PreferencesServiceClient

Updated associated usage of manager/observer in code to service/client.
Updated PrefObserverStore to PrefClientStore.

TEST=manual, preferences_unittests, unit_tests
BUG=674138
==========

to

==========
Unify Preferences Mojom Naming to PreferencesService

Renaming:
PreferencesManager  - PreferencesService
PreferencesFactory  - PreferencesServiceFactory
PreferencesObserver - PreferencesServiceClient

Updated associated usage of manager/observer in code to service/client.
Updated PrefObserverStore to PrefClientStore.

TEST=manual, preferences_unittests, unit_tests
BUG=674138

Review-Url: https://codereview.chromium.org/2644893003
Cr-Commit-Position: refs/heads/master@{#449796}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fce105a2049f924de6c4d7dc416...
==========

[commit-bot: I haz the power, 2017-02-11 00:05:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0fce105a2049f924de6c4d7dc416...