Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(803)

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

Issue 2644873002: [Sensors] Fix reading updates after page refresh (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
index ca953a0af354e9f4d43328dda1ce6520ebee87a1..f25b39e1165cfa0fe618e797fcb9894352560b3f 100644
--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp
@@ -18,16 +18,15 @@ namespace blink {
SensorProxy::SensorProxy(SensorType sensorType,
SensorProviderProxy* provider,
- Document* document,
+ Page* page,
std::unique_ptr<SensorReadingFactory> readingFactory)
- : PageVisibilityObserver(document->page()),
+ : PageVisibilityObserver(page),
m_type(sensorType),
m_mode(ReportingMode::CONTINUOUS),
m_provider(provider),
m_clientBinding(this),
m_state(SensorProxy::Uninitialized),
m_suspended(false),
- m_document(document),
m_readingFactory(std::move(readingFactory)),
m_maximumFrequency(0.0) {}
@@ -38,7 +37,6 @@ void SensorProxy::dispose() {
}
DEFINE_TRACE(SensorProxy) {
- visitor->trace(m_document);
visitor->trace(m_readingUpdater);
visitor->trace(m_reading);
visitor->trace(m_observers);
@@ -120,6 +118,10 @@ const SensorConfiguration* SensorProxy::defaultConfig() const {
return m_defaultConfig.get();
}
+Document* SensorProxy::document() const {
+ return m_provider->supplementable()->document();
+}
+
void SensorProxy::updateSensorReading() {
DCHECK(isInitialized());
DCHECK(m_readingFactory);
@@ -263,6 +265,9 @@ void SensorProxy::onRemoveConfigurationCompleted(double frequency,
}
m_frequenciesUsed.remove(index);
+
+ if (m_frequenciesUsed.isEmpty())
+ m_readingUpdater->reset();
}
bool SensorProxy::tryReadFromBuffer(device::SensorReading& result) {

Powered by Google App Engine
This is Rietveld 408576698