third_party/WebKit/Source/modules/sensor/Sensor.cpp - Issue 2644873002: [Sensors] Fix reading updates after page refresh

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/Sensor.cpp

Issue 2644873002: [Sensors] Fix reading updates after page refresh (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/Sensor.cpp

diff --git a/third_party/WebKit/Source/modules/sensor/Sensor.cpp b/third_party/WebKit/Source/modules/sensor/Sensor.cpp

index b4ad6bab959116b20a2fa6d1c1a0eae5a4f7bc14..ac012048b0e66101a77e28407a8a5900d2df190a 100644

--- a/third_party/WebKit/Source/modules/sensor/Sensor.cpp

+++ b/third_party/WebKit/Source/modules/sensor/Sensor.cpp

@@ -164,7 +164,7 @@ void Sensor::initSensorProxyIfNeeded() {

m_sensorProxy = provider->getSensorProxy(m_type);

if (!m_sensorProxy) {

- m_sensorProxy = provider->createSensorProxy(m_type, document,

+ m_sensorProxy = provider->createSensorProxy(m_type, document->page(),

shalamov 2017/01/20 09:25:32 should we throw "InvalidStateError" if context is

Mikhail 2017/01/24 12:00:18 page is used only in PageVisibilityObserver which

createSensorReadingFactory());

}