Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(866)

Issue 2644853003: [runtime] Always request kMutable constness when reconfiguring to a field. (Closed)

Created:
3 years, 11 months ago by Igor Sheludko
Modified:
3 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[runtime] Always request kMutable constness when reconfiguring to a field. BUG=chromium:682706 Review-Url: https://codereview.chromium.org/2644853003 Cr-Commit-Position: refs/heads/master@{#42554} Committed: https://chromium.googlesource.com/v8/v8/+/d02ca3625f9f496fa5374f8582c137cf5a6ba883

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/map-updater.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
Igor Sheludko
PTAL
3 years, 11 months ago (2017-01-20 09:59:08 UTC) #4
Jakob Kummerow
lgtm
3 years, 11 months ago (2017-01-20 12:11:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644853003/1
3 years, 11 months ago (2017-01-20 13:15:05 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 13:17:09 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d02ca3625f9f496fa5374f8582c137cf5a6...

Powered by Google App Engine
This is Rietveld 408576698