Use explicit WebString conversion methods in content/renderer/media (unittests)

Use explicit WebString conversion methods in content/renderer/media (unittests)

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
Review-Url: https://codereview.chromium.org/2644853002
Cr-Commit-Position: refs/heads/master@{#444994}
Committed: https://chromium.googlesource.com/chromium/src/+/a7687681877feabf6a4266e8003252290a461132

[kinuko, 2017-01-19 10:38:14]

The CQ bit was checked by kinuko@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 10:38:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 10:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 10:59:55]

Dry run: This issue passed the CQ dry run.

[kinuko, 2017-01-19 12:37:38]

Description was changed from

==========
Use explicit WebString conversion methods in content/renderer/media (unittests)

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversion methods in content/renderer/media (unittests)

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

[kinuko, 2017-01-19 12:37:39]

kinuko@chromium.org changed reviewers:
+ jrummell@chromium.org

[kinuko, 2017-01-19 12:38:18]

Yet another one, mostly mechanical changes only. PTL

[jrummell, 2017-01-19 20:17:03]

Thanks for doing this. lgtm (with question).

https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):

https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
content/renderer/media/rtc_peer_connection_handler_unittest.cc:338:
local_stream.initialize(blink::WebString::fromUTF8(stream_label),
Most of the conversions of UTF8ToUTF16() became fromASCII(). This one is
different. Is that by design? (Also the 1 change in
mock_media_stream_registry.cc.)

[kinuko, 2017-01-20 02:22:35]

Thanks,

https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):

https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
content/renderer/media/rtc_peer_connection_handler_unittest.cc:338:
local_stream.initialize(blink::WebString::fromUTF8(stream_label),
On 2017/01/19 20:17:03, jrummell wrote:
> Most of the conversions of UTF8ToUTF16() became fromASCII(). This one is
> different. Is that by design? (Also the 1 change in
> mock_media_stream_registry.cc.)

I wasn't sure if this method always takes ascii stream_label or not (while
others are just taking constants, so it was easy to guess).  Either should work
if it's ascii (fromASCII is slightly faster), while we need to use fromUTF8
otherwise.  (Since we're in the testing code we could also fallback to always
use fromUTF8 to simplify these, if you prefer)

[kinuko, 2017-01-20 06:05:32]

On 2017/01/20 02:22:35, kinuko wrote:
> Thanks,
> 
>
https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
> File content/renderer/media/rtc_peer_connection_handler_unittest.cc (right):
> 
>
https://codereview.chromium.org/2644853002/diff/1/content/renderer/media/rtc_...
> content/renderer/media/rtc_peer_connection_handler_unittest.cc:338:
> local_stream.initialize(blink::WebString::fromUTF8(stream_label),
> On 2017/01/19 20:17:03, jrummell wrote:
> > Most of the conversions of UTF8ToUTF16() became fromASCII(). This one is
> > different. Is that by design? (Also the 1 change in
> > mock_media_stream_registry.cc.)
> 
> I wasn't sure if this method always takes ascii stream_label or not (while
> others are just taking constants, so it was easy to guess).  Either should
work
> if it's ascii (fromASCII is slightly faster), while we need to use fromUTF8
> otherwise.  (Since we're in the testing code we could also fallback to always
> use fromUTF8 to simplify these, if you prefer)

(I'm landing this but please feel free to reply back or create a follow-up patch
if we want to make these changes^^)

[kinuko, 2017-01-20 06:05:37]

The CQ bit was checked by kinuko@chromium.org

[commit-bot: I haz the power, 2017-01-20 06:05:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 06:10:30]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484892337048090, "parent_rev":
"aa90ea1cec4f6bcc64a494c9a150e16f0e01c508", "commit_rev":
"a7687681877feabf6a4266e8003252290a461132"}

[commit-bot: I haz the power, 2017-01-20 06:11:02]

Description was changed from

==========
Use explicit WebString conversion methods in content/renderer/media (unittests)

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131
==========

to

==========
Use explicit WebString conversion methods in content/renderer/media (unittests)

As we're deprecating implicit conversions for WebString <-> string16
replace them with explicit methods. (See crbug.com/667131 for more
details)

BUG=667131

Review-Url: https://codereview.chromium.org/2644853002
Cr-Commit-Position: refs/heads/master@{#444994}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7687681877feabf6a4266e80032...
==========

[commit-bot: I haz the power, 2017-01-20 06:11:03]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a7687681877feabf6a4266e80032...