Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 2644843006: Use packages dart_parser, dart_scanner, and compiler_util. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/fasta
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+223 lines, -7157 lines) Patch
M pkg/compiler/lib/src/closure.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 3 chunks +7 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 4 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 1 chunk +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/compiler/lib/src/parser/class_element_parser.dart View 1 chunk +0 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 6 chunks +29 lines, -11 lines 1 comment Download
D pkg/compiler/lib/src/parser/listener.dart View 1 chunk +0 lines, -637 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 4 chunks +12 lines, -7 lines 0 comments Download
D pkg/compiler/lib/src/parser/parser.dart View 1 chunk +0 lines, -3007 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 3 chunks +9 lines, -9 lines 0 comments Download
D pkg/compiler/lib/src/parser/partial_parser.dart View 1 chunk +0 lines, -175 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 4 chunks +6 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 chunk +3 lines, -4 lines 1 comment Download
M pkg/compiler/lib/src/resolution/members.dart View 6 chunks +13 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -1 line 0 comments Download
D pkg/compiler/lib/src/scanner/array_based_scanner.dart View 1 chunk +0 lines, -233 lines 0 comments Download
D pkg/compiler/lib/src/scanner/scanner.dart View 1 chunk +0 lines, -1187 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 3 chunks +15 lines, -8 lines 0 comments Download
D pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +0 lines, -62 lines 0 comments Download
D pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 1 chunk +0 lines, -214 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/serialization/resolved_ast_serialization.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/system.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 2 chunks +4 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/tokens/keyword.dart View 1 chunk +0 lines, -215 lines 0 comments Download
D pkg/compiler/lib/src/tokens/precedence.dart View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/compiler/lib/src/tokens/precedence_constants.dart View 1 chunk +0 lines, -189 lines 0 comments Download
D pkg/compiler/lib/src/tokens/token.dart View 1 chunk +0 lines, -430 lines 0 comments Download
D pkg/compiler/lib/src/tokens/token_constants.dart View 1 chunk +0 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token_map.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/dartstring.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 3 chunks +14 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 chunk +2 lines, -2 lines 0 comments Download
D pkg/compiler/lib/src/util/characters.dart View 1 chunk +0 lines, -143 lines 0 comments Download
D pkg/compiler/lib/src/util/link.dart View 1 chunk +0 lines, -172 lines 0 comments Download
D pkg/compiler/lib/src/util/link_implementation.dart View 1 chunk +0 lines, -218 lines 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 chunk +3 lines, -3 lines 0 comments Download
D pkg/compiler/lib/src/util/util_implementation.dart View 1 chunk +0 lines, -11 lines 0 comments Download
M pkg/dart_parser/lib/dart_parser.dart View 1 chunk +15 lines, -1 line 0 comments Download
M pkg/dart_scanner/lib/dart_scanner.dart View 1 chunk +25 lines, -0 lines 0 comments Download
A + pkg/dart_scanner/lib/src/string_scanner.dart View 2 chunks +17 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 6 (2 generated)
ahe
https://codereview.chromium.org/2644843006/diff/1/pkg/compiler/lib/src/parser/element_listener.dart File pkg/compiler/lib/src/parser/element_listener.dart (right): https://codereview.chromium.org/2644843006/diff/1/pkg/compiler/lib/src/parser/element_listener.dart#newcode610 pkg/compiler/lib/src/parser/element_listener.dart:610: // TODO(ahe): XXX I'll remove the XXX comments in ...
3 years, 11 months ago (2017-01-20 16:50:35 UTC) #2
Siggi Cherem (dart-lang)
nice! lgtm
3 years, 11 months ago (2017-01-20 17:24:11 UTC) #3
Johnni Winther
LGTM
3 years, 11 months ago (2017-01-23 09:33:35 UTC) #4
ahe
3 years, 11 months ago (2017-01-23 11:08:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
51c03430a916391ea1c5be07e73b227ef4f5fbba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698