Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 2642903003: Update parser and scanner. (Closed)

Created:
3 years, 11 months ago by ahe
Modified:
3 years, 11 months ago
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com, floitsch
Target Ref:
refs/heads/fasta
Project:
Fasta
Visibility:
Public.

Description

Update parser and scanner. Up-to-date with 919b5ac8d0588f74b1bff6d77297f2916752560b. R=johnniwinther@google.com, sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/17dac82539e2f0b47d5f57f10d8cc7a94508e851

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -462 lines) Patch
M pkg/dart_parser/lib/dart_parser.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/dart_parser/lib/src/class_member_parser.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/dart_parser/lib/src/parser.dart View 20 chunks +53 lines, -57 lines 0 comments Download
M pkg/dart_parser/lib/src/top_level_parser.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/dart_parser/test/parser.status View 8 chunks +378 lines, -387 lines 0 comments Download
M pkg/dart_scanner/lib/src/keyword.dart View 2 chunks +2 lines, -1 line 0 comments Download
M pkg/fasta/lib/src/source/diet_parser.dart View 1 chunk +2 lines, -5 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
ahe
3 years, 11 months ago (2017-01-19 14:52:25 UTC) #3
Johnni Winther
lgtm
3 years, 11 months ago (2017-01-19 15:15:31 UTC) #4
Siggi Cherem (dart-lang)
lgtm FYI - we just rolled back a change to add generalized function-type syntax, if ...
3 years, 11 months ago (2017-01-19 16:19:12 UTC) #5
ahe
On 2017/01/19 16:19:12, Siggi Cherem (dart-lang) wrote: > lgtm > > FYI - we just ...
3 years, 11 months ago (2017-01-23 11:01:07 UTC) #6
ahe
3 years, 11 months ago (2017-01-23 11:04:46 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
17dac82539e2f0b47d5f57f10d8cc7a94508e851 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698