Convert MediaControlElements timer to UnspecedTimer per-frame TaskRunnerTimer.

Convert MediaControlElements timer to UnspecedTimer per-frame TaskRunnerTimer.

BUG=624694
Review-Url: https://codereview.chromium.org/2644823002
Cr-Commit-Position: refs/heads/master@{#447708}
Committed: https://chromium.googlesource.com/chromium/src/+/ac9c9ce56b2aa40ddd5387f8784d939f4809af04

[joelhockey, 2017-01-19 12:39:55]

joelhockey@chromium.org changed reviewers:
+ sashab@chromium.org, slangley@chromium.org

[sashab, 2017-01-20 02:16:53]

LG*M :)

[mlamouri (slow - plz ping), 2017-01-23 00:00:39]

mlamouri@chromium.org changed reviewers:
+ mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-23 00:00:39]

sgtm but I have a drive-by comment, see below.

https://codereview.chromium.org/2644823002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp
(right):

https://codereview.chromium.org/2644823002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp:134:
m_transitionTimer(TaskRunnerHelper::get(TaskType::MediaElementEvent,
Ideally, MediaControlElements shouldn't be noticeably different from custom
controls in JS. Is there a generic TaskType that could be used instead of
MediaElementEvent?

[joelhockey, 2017-02-02 00:58:34]

joelhockey@chromium.org changed reviewers:
+ haraken@chromium.org

[joelhockey, 2017-02-02 01:00:07]

On 2017/02/02 at 00:58:34, joelhockey wrote:
> joelhockey@chromium.org changed reviewers:
> + haraken@chromium.org

haraken, PTAL.  Do you have any thoughts about mlamouri's comment for the
TaskType?  Should I use UnspecedTimer?

[joelhockey, 2017-02-02 01:01:38]

The CQ bit was checked by joelhockey@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-02 01:02:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 04:22:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-02 04:22:16]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-02-02 04:28:32]

On 2017/02/02 01:00:07, joelhockey wrote:
> On 2017/02/02 at 00:58:34, joelhockey wrote:
> > mailto:joelhockey@chromium.org changed reviewers:
> > + mailto:haraken@chromium.org
> 
> haraken, PTAL.  Do you have any thoughts about mlamouri's comment for the
> TaskType?  Should I use UnspecedTimer?

Yeah, UnspecedTimer sounds reasonable. With that change, LGTM.

[joelhockey, 2017-02-02 04:34:09]

Description was changed from

==========
Convert MediaControlElements timer to MediaElementEvent per-frame
TaskRunnerTimer.

BUG=624694
==========

to

==========
Convert MediaControlElements timer to UnspecedTimer per-frame TaskRunnerTimer.

BUG=624694
==========

[joelhockey, 2017-02-02 04:34:41]

The CQ bit was checked by joelhockey@chromium.org

[joelhockey, 2017-02-02 04:34:41]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2644823002/#ps40001
(title: "Convert timer to MediaElementEvent per-frame TaskRunnerTimer.")

[commit-bot: I haz the power, 2017-02-02 04:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-02 06:29:12]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486010081264660,
"parent_rev": "7aee106060efcc49f9768365b77f1ea697b17230", "commit_rev":
"ac9c9ce56b2aa40ddd5387f8784d939f4809af04"}

[commit-bot: I haz the power, 2017-02-02 06:29:44]

Description was changed from

==========
Convert MediaControlElements timer to UnspecedTimer per-frame TaskRunnerTimer.

BUG=624694
==========

to

==========
Convert MediaControlElements timer to UnspecedTimer per-frame TaskRunnerTimer.

BUG=624694

Review-Url: https://codereview.chromium.org/2644823002
Cr-Commit-Position: refs/heads/master@{#447708}
Committed:
https://chromium.googlesource.com/chromium/src/+/ac9c9ce56b2aa40ddd5387f8784d...
==========

[commit-bot: I haz the power, 2017-02-02 06:29:53]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/ac9c9ce56b2aa40ddd5387f8784d...