chromeos: Split laser tests into two files.

chromeos: Split laser tests into two files.

Previously two laser tests testing two different parts of the laser resided in the same file.

BUG=646953
TEST=ash_unittest --gtest_filter="LaserPointer*"

Review-Url: https://codereview.chromium.org/2644793004
Cr-Commit-Position: refs/heads/master@{#444917}
Committed: https://chromium.googlesource.com/chromium/src/+/e5f251a9f6bba0c9ec4354f1aab94f06047428b3

[sammiequon, 2017-01-19 19:48:35]

The CQ bit was checked by sammiequon@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 19:49:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 21:03:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 21:03:18]

Dry run: This issue passed the CQ dry run.

[sammiequon, 2017-01-19 22:05:35]

Description was changed from

==========
chromeos: Split laser tests into two files.

Previously two laser tests testing two different parts of the laser resided in
the same file.

BUG=646953
TEST=ash_unittest --gtest_filter="LaserPointer*"
==========

to

==========
chromeos: Split laser tests into two files.

Previously two laser tests testing two different parts of the laser resided in
the same file.

BUG=646953
TEST=ash_unittest --gtest_filter="LaserPointer*"
==========

[sammiequon, 2017-01-19 22:05:35]

sammiequon@chromium.org changed reviewers:
+ jamescook@chromium.org

[sammiequon, 2017-01-19 22:05:57]

On 2017/01/19 22:05:35, sammiequon wrote:
> mailto:sammiequon@chromium.org changed reviewers:
> + mailto:jamescook@chromium.org

jamescook@ - Please take a look. Thanks!

[James Cook, 2017-01-19 22:10:17]

LGTM with nit

https://codereview.chromium.org/2644793004/diff/1/ash/laser/laser_pointer_poi...
File ash/laser/laser_pointer_points_unittest.cc (right):

https://codereview.chromium.org/2644793004/diff/1/ash/laser/laser_pointer_poi...
ash/laser/laser_pointer_points_unittest.cc:5: #include
"ash/laser/laser_pointer_points_test_api.h"
nit: #include the file under test (laser_pointer_points.h?)

[sammiequon, 2017-01-20 00:00:39]

https://codereview.chromium.org/2644793004/diff/1/ash/laser/laser_pointer_poi...
File ash/laser/laser_pointer_points_unittest.cc (right):

https://codereview.chromium.org/2644793004/diff/1/ash/laser/laser_pointer_poi...
ash/laser/laser_pointer_points_unittest.cc:5: #include
"ash/laser/laser_pointer_points_test_api.h"
On 2017/01/19 22:10:16, James Cook wrote:
> nit: #include the file under test (laser_pointer_points.h?)

Done.

[sammiequon, 2017-01-20 00:00:42]

The CQ bit was checked by sammiequon@chromium.org

[sammiequon, 2017-01-20 00:00:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2644793004/#ps40001
(title: "Fixed patch set 1 errors.")

[commit-bot: I haz the power, 2017-01-20 00:02:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 01:21:15]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484870442459700,
"parent_rev": "6a12d2a71af9f026d50076d111c50c7ebd85a431", "commit_rev":
"e5f251a9f6bba0c9ec4354f1aab94f06047428b3"}

[commit-bot: I haz the power, 2017-01-20 01:21:48]

Description was changed from

==========
chromeos: Split laser tests into two files.

Previously two laser tests testing two different parts of the laser resided in
the same file.

BUG=646953
TEST=ash_unittest --gtest_filter="LaserPointer*"
==========

to

==========
chromeos: Split laser tests into two files.

Previously two laser tests testing two different parts of the laser resided in
the same file.

BUG=646953
TEST=ash_unittest --gtest_filter="LaserPointer*"

Review-Url: https://codereview.chromium.org/2644793004
Cr-Commit-Position: refs/heads/master@{#444917}
Committed:
https://chromium.googlesource.com/chromium/src/+/e5f251a9f6bba0c9ec4354f1aab9...
==========

[commit-bot: I haz the power, 2017-01-20 01:21:49]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e5f251a9f6bba0c9ec4354f1aab9...