Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 2644763002: Rename Launch MyComputer/Calculator to Application1/2 (Closed)

Created:
3 years, 11 months ago by garykac
Modified:
3 years, 10 months ago
Reviewers:
chongz
CC:
chromium-reviews, tdresser+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Launch MyComputer/Calculator to Application1/2 https://github.com/w3c/uievents-key/issues/27 BUG=612743 Review-Url: https://codereview.chromium.org/2644763002 Cr-Commit-Position: refs/heads/master@{#448776} Committed: https://chromium.googlesource.com/chromium/src/+/5050e17b6d5259f873447ffc57bf274af2a189a1

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M ui/events/keycodes/dom/dom_key_data.inc View 1 chunk +2 lines, -4 lines 2 comments Download

Messages

Total messages: 13 (8 generated)
garykac
3 years, 11 months ago (2017-01-19 00:18:11 UTC) #3
chongz
Thanks for the patch! LGTM with a note. https://codereview.chromium.org/2644763002/diff/1/ui/events/keycodes/dom/dom_key_data.inc File ui/events/keycodes/dom/dom_key_data.inc (right): https://codereview.chromium.org/2644763002/diff/1/ui/events/keycodes/dom/dom_key_data.inc#newcode352 ui/events/keycodes/dom/dom_key_data.inc:352: DOM_KEY_MAP("LaunchApplication1", ...
3 years, 11 months ago (2017-01-19 16:33:09 UTC) #7
chongz
https://codereview.chromium.org/2644763002/diff/1/ui/events/keycodes/dom/dom_key_data.inc File ui/events/keycodes/dom/dom_key_data.inc (right): https://codereview.chromium.org/2644763002/diff/1/ui/events/keycodes/dom/dom_key_data.inc#newcode352 ui/events/keycodes/dom/dom_key_data.inc:352: DOM_KEY_MAP("LaunchApplication1", LAUNCH_MY_COMPUTER, 0x0B06), On 2017/01/19 16:33:09, chongz wrote: > ...
3 years, 11 months ago (2017-01-19 16:47:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644763002/1
3 years, 10 months ago (2017-02-07 21:52:46 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 23:17:35 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5050e17b6d5259f873447ffc57bf...

Powered by Google App Engine
This is Rietveld 408576698