Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2644733007: [turbofan] Check for nullptr maps. (Closed)

Created:
3 years, 11 months ago by Franzi
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Check for nullptr maps. ReduceJSStoreDataPropertyInLiteral should not reduce the monomorphic case if the map got deleted. This has been fixed before in the context of a larger commit, which was reverted. R=adamk@chromium.org, mvstanton@chromium.org, bmeurer@chromium.org BUG=v8:5873 Review-Url: https://codereview.chromium.org/2644733007 Cr-Commit-Position: refs/heads/master@{#42548} Committed: https://chromium.googlesource.com/v8/v8/+/dd8881a5c406496427e4ba794b651af8ed3de213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M src/compiler/js-native-context-specialization.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
Franzi
Fix for the bug found with gcstress testing. Mike had fixed that before as part ...
3 years, 11 months ago (2017-01-20 09:31:02 UTC) #3
Benedikt Meurer
lgtm
3 years, 11 months ago (2017-01-20 09:43:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2644733007/1
3 years, 11 months ago (2017-01-20 10:13:38 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 10:50:22 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/dd8881a5c406496427e4ba794b651af8ed3...

Powered by Google App Engine
This is Rietveld 408576698