MD History: Scroll history-items into view when their action menu is opened

MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG=639783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2644733003
Cr-Commit-Position: refs/heads/master@{#444646}
Committed: https://chromium.googlesource.com/chromium/src/+/997841c120ef5c64f5ae10392619a88c0462fedd

[tsergeant, 2017-01-19 02:45:47]

Description was changed from

==========
MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG=639783
==========

to

==========
MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG=639783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tsergeant, 2017-01-19 02:46:07]

The CQ bit was checked by tsergeant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-19 02:46:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tsergeant, 2017-01-19 03:04:26]

tsergeant@chromium.org changed reviewers:
+ calamity@chromium.org

[tsergeant, 2017-01-19 03:04:26]

WDYT?

I didn't write a test since we're not well equipped to deal with off-screen
iron-list items in tests.

[commit-bot: I haz the power, 2017-01-19 03:40:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-19 03:40:20]

Dry run: This issue passed the CQ dry run.

[calamity, 2017-01-19 04:48:02]

lgtm

[tsergeant, 2017-01-19 04:50:16]

The CQ bit was checked by tsergeant@chromium.org

[commit-bot: I haz the power, 2017-01-19 04:50:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-19 04:55:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484801416997410, "parent_rev":
"3c3fc44213f04f41c2e9dedcd37da29f5b167f1c", "commit_rev":
"997841c120ef5c64f5ae10392619a88c0462fedd"}

[commit-bot: I haz the power, 2017-01-19 04:56:06]

Description was changed from

==========
MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG=639783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
MD History: Scroll history-items into view when their action menu is opened

It is possible to use keyboard shortcuts to open the action menu of an
off-screen history-item. This does not cause any visible change, but
prevents scrolling until the (invisible) menu is closed by clicking or
pressing escape.

This CL fixes this behavior by ensuring that off-screen history-items
are scrolled into view when their menu is opened.

BUG=639783
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2644733003
Cr-Commit-Position: refs/heads/master@{#444646}
Committed:
https://chromium.googlesource.com/chromium/src/+/997841c120ef5c64f5ae10392619...
==========

[commit-bot: I haz the power, 2017-01-19 04:56:09]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/997841c120ef5c64f5ae10392619...